Bug 166530 - [css-grid] Isolate instrinsic size computation from layout
Summary: [css-grid] Isolate instrinsic size computation from layout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks: 165007
  Show dependency tree / graph
 
Reported: 2016-12-28 06:12 PST by Sergio Villar Senin
Modified: 2016-12-30 03:00 PST (History)
8 users (show)

See Also:

Attachments
Patch (23.42 KB, patch)
2016-12-28 06:17 PST, Sergio Villar Senin 		darin: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-elcapitan (2.16 MB, application/zip)
2016-12-28 07:46 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2016-12-28 06:12:24 PST 
[css-grid] Isolate instrinsic size computation from layout
Comment 1 Sergio Villar Senin 2016-12-28 06:17:59 PST 
Created attachment 297802 [details]
Patch
Comment 2 Build Bot 2016-12-28 07:46:54 PST 
Comment on attachment 297802 [details]
Patch

Attachment 297802 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2798529

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2016-12-28 07:46:57 PST 
Created attachment 297808 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Sergio Villar Senin 2016-12-30 02:54:56 PST 
Committed r210211: <http://trac.webkit.org/changeset/210211>
Comment 5 Sergio Villar Senin 2016-12-30 03:00:07 PST 
(In reply to comment #3)
> Created attachment 297808 [details]
> Archive of layout-test-results from ews112 for mac-elcapitan
> 
> The attached test failures were seen while running run-webkit-tests on the
> mac-debug-ews.
> Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

This was caused by an oversight inside an ASSERT. I forgot to replace an instance of m_grid by grid in RenderGrid::numTracks(), that's why tests were hitting the assertion.

It was properly fixed before landing.