Bug 166524 – REGRESSION(r99965): Web Inspector: large inline scripts and text nodes are truncated at 10,000 characters

• Status: NEW
• Component: Web Inspector

[Blaze Burg]

<rdar://problem/13465082>

[Blaze Burg]

Created attachment 297792 [details]
[PATCH] Cumulative Diff (for EWS)

[Blaze Burg]

Created attachment 297793 [details]
[PATCH 1/3] WrappedPromise changes

[Blaze Burg]

Created attachment 297794 [details]
[PATCH 2/3] Add promises to DOMTreeManager

[Blaze Burg]

Created attachment 297795 [details]
[PATCH 3/3] Fix the bug and add a regression test

[Blaze Burg]

Comment on attachment 297793 [details]
[PATCH 1/3] WrappedPromise changes

This patch is tracked by a separate bug, but I added it here for reference and so EWS would work.

[Build Bot]

Comment on attachment 297792 [details]
[PATCH] Cumulative Diff (for EWS)

Attachment 297792 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2796007

New failing tests:
inspector/css/generate-css-rule-string.html
inspector/css/stylesheet-with-mutations.html
inspector/dom/domutilities-path-dump.html
inspector/dom/shadowRootType.html
inspector/dom/setOuterHTML.html
inspector/dom/customElementState.html
inspector/dom/highlight-shape-outside-margin.html
inspector/dom/domutilities-xpath.html
inspector/dom/pseudo-element-dynamic.html
inspector/dom/domutilities-csspath.html
inspector/dom/hideHighlight.html
inspector/dom/getOuterHTML.html
inspector/dom/pseudo-element-static.html
inspector/dom/csp-hash.html
inspector/console/addInspectedNode.html
inspector/dom/csp-big5-hash.html
inspector/dom/highlightNode.html
inspector/console/command-line-api.html
inspector/css/shadow-scoped-style.html
inspector/dom/template-content.html
http/tests/inspector/console/cross-domain-inspected-node-access.html

[Build Bot]

Created attachment 297797 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297792 [details]
[PATCH] Cumulative Diff (for EWS)

Attachment 297792 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2796024

New failing tests:
inspector/css/generate-css-rule-string.html
inspector/css/stylesheet-with-mutations.html
inspector/dom/domutilities-path-dump.html
inspector/dom/shadowRootType.html
inspector/dom/customElementState.html
inspector/dom/highlight-shape-outside-margin.html
inspector/dom/domutilities-xpath.html
inspector/dom/setOuterHTML.html
inspector/dom/domutilities-csspath.html
inspector/dom/hideHighlight.html
inspector/dom/getOuterHTML.html
inspector/dom/pseudo-element-static.html
inspector/dom/csp-hash.html
inspector/dom/pseudo-element-dynamic.html
inspector/dom/csp-big5-hash.html
inspector/dom/highlightNode.html
inspector/console/command-line-api.html
inspector/css/shadow-scoped-style.html
inspector/dom/template-content.html
http/tests/inspector/console/cross-domain-inspected-node-access.html

[Build Bot]

Created attachment 297798 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297792 [details]
[PATCH] Cumulative Diff (for EWS)

Attachment 297792 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2796145

New failing tests:
inspector/css/generate-css-rule-string.html
inspector/css/stylesheet-with-mutations.html
inspector/dom/domutilities-path-dump.html
inspector/dom/shadowRootType.html
inspector/dom/setOuterHTML.html
inspector/dom/customElementState.html
inspector/dom/highlight-shape-outside-margin.html
inspector/dom/domutilities-xpath.html
inspector/dom/pseudo-element-dynamic.html
inspector/dom/domutilities-csspath.html
inspector/dom/hideHighlight.html
inspector/dom/getOuterHTML.html
inspector/dom/pseudo-element-static.html
inspector/dom/csp-hash.html
inspector/console/addInspectedNode.html
inspector/dom/csp-big5-hash.html
inspector/dom/highlightNode.html
inspector/console/command-line-api.html
inspector/css/shadow-scoped-style.html
inspector/dom/template-content.html
http/tests/inspector/console/cross-domain-inspected-node-access.html

[Build Bot]

Created attachment 297799 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297794 [details]
[PATCH 2/3] Add promises to DOMTreeManager

Attachment 297794 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2803784

New failing tests:
inspector/css/generate-css-rule-string.html
inspector/css/stylesheet-with-mutations.html
inspector/dom/domutilities-path-dump.html
inspector/dom/shadowRootType.html
http/tests/inspector/console/cross-domain-inspected-node-access.html
inspector/dom/setOuterHTML.html
inspector/dom/customElementState.html
inspector/dom/highlight-shape-outside-margin.html
inspector/dom/domutilities-xpath.html
inspector/dom/pseudo-element-dynamic.html
inspector/dom/domutilities-csspath.html
inspector/dom/hideHighlight.html
inspector/dom/getOuterHTML.html
inspector/dom/pseudo-element-static.html
inspector/dom/csp-hash.html
inspector/console/addInspectedNode.html
inspector/dom/csp-big5-hash.html
inspector/dom/highlightNode.html
inspector/css/shadow-scoped-style.html
inspector/dom/template-content.html
inspector/console/command-line-api.html

[Build Bot]

Created attachment 297839 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297794 [details]
[PATCH 2/3] Add promises to DOMTreeManager

Attachment 297794 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2803911

New failing tests:
inspector/css/generate-css-rule-string.html
inspector/css/stylesheet-with-mutations.html
inspector/dom/domutilities-path-dump.html
inspector/dom/shadowRootType.html
http/tests/inspector/console/cross-domain-inspected-node-access.html
inspector/console/addInspectedNode.html
inspector/dom/customElementState.html
inspector/dom/highlight-shape-outside-margin.html
inspector/dom/domutilities-xpath.html
inspector/dom/setOuterHTML.html
inspector/dom/domutilities-csspath.html
inspector/dom/template-content.html
inspector/dom/hideHighlight.html
inspector/dom/getOuterHTML.html
inspector/dom/csp-hash.html
inspector/dom/pseudo-element-dynamic.html
inspector/dom/csp-big5-hash.html
inspector/dom/highlightNode.html
inspector/css/shadow-scoped-style.html
inspector/dom/pseudo-element-static.html
inspector/console/command-line-api.html

[Build Bot]

Created attachment 297843 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297794 [details]
[PATCH 2/3] Add promises to DOMTreeManager

Attachment 297794 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2804132

New failing tests:
inspector/css/generate-css-rule-string.html
inspector/css/stylesheet-with-mutations.html
inspector/dom/domutilities-path-dump.html
inspector/dom/shadowRootType.html
inspector/dom/customElementState.html
inspector/dom/highlight-shape-outside-margin.html
inspector/dom/domutilities-xpath.html
inspector/dom/setOuterHTML.html
inspector/dom/domutilities-csspath.html
inspector/dom/hideHighlight.html
inspector/dom/getOuterHTML.html
inspector/dom/pseudo-element-static.html
inspector/dom/csp-hash.html
inspector/dom/pseudo-element-dynamic.html
inspector/dom/csp-big5-hash.html
inspector/dom/highlightNode.html
inspector/console/command-line-api.html
inspector/css/shadow-scoped-style.html
inspector/dom/template-content.html
http/tests/inspector/console/cross-domain-inspected-node-access.html

[Build Bot]

Created attachment 297844 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Joseph Pecoraro]

Comment on attachment 297793 [details]
[PATCH 1/3] WrappedPromise changes

This moved into its own bug apparently (Bug 166523)

[Joseph Pecoraro]

Comment on attachment 297795 [details]
[PATCH 3/3] Fix the bug and add a regression test

This change looks fine to me, but lots of tests are failing. Those should be investigated.

[Joseph Pecoraro]

Comment on attachment 297794 [details]
[PATCH 2/3] Add promises to DOMTreeManager

View in context: https://bugs.webkit.org/attachment.cgi?id=297794&action=review

> Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:-108
> -            callback(error ? null : result);

It looks like this old code would run the callback with null if there was an error. New code passes the error string.

[Joseph Pecoraro]

Comment on attachment 297792 [details]
[PATCH] Cumulative Diff (for EWS)

r- due to the tests failing, but see comments on the other parts which points out a change that may have caused this.

[Blaze Burg]

(In reply to comment #21)
> Comment on attachment 297792 [details]
> [PATCH] Cumulative Diff (for EWS)
> 
> r- due to the tests failing, but see comments on the other parts which
> points out a change that may have caused this.

This patch series was uploaded prior to fixing all of the tests. Since that task got so big, I moved it into this separate bug:

https://bugs.webkit.org/show_bug.cgi?id=166634

That in turn is blocked on the WrappedPromise and reportUnhandledRejection bugs, which are in commit-queue now. I'll rebase and re-upload what's remaining to this bug and 166634 tonight or tomorrow so they have accurate EWS results.