Bug 166490 - WebAssembly: Don't allow duplicate export names
Summary: WebAssembly: Don't allow duplicate export names
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-27 10:19 PST by Saam Barati
Modified: 2016-12-29 08:51 PST (History)
13 users (show)

See Also:

Attachments
patch (3.88 KB, patch)
2016-12-28 16:31 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-12-27 10:19:47 PST 
...
Comment 1 Radar WebKit Bug Importer 2016-12-27 10:30:34 PST 
<rdar://problem/29815000>
Comment 2 Saam Barati 2016-12-27 10:34:10 PST 
Looks like this requires my grow_memory patch to fix the test which fixes creating memory w/ initial size of zero.
Comment 3 Saam Barati 2016-12-28 16:31:03 PST 
Created attachment 297816 [details]
patch
Comment 4 Keith Miller 2016-12-28 18:39:25 PST 
Comment on attachment 297816 [details]
patch

r=me.
Comment 5 WebKit Commit Bot 2016-12-28 19:10:54 PST 
Comment on attachment 297816 [details]
patch

Clearing flags on attachment: 297816

Committed r210203: <http://trac.webkit.org/changeset/210203>
Comment 6 WebKit Commit Bot 2016-12-28 19:11:00 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 JF Bastien 2016-12-29 08:51:17 PST 
Hmm, I find this surprising since duplicates aren't useful but are also harmless. I filed a PR in the design repo to add this restriction:
https://github.com/WebAssembly/design/pull/932

It seems silly to restrict when overwrite semantics is clear and requires less work.

In any case, this is a good PR to follow the spec, a nice corner case, and reversing polarity is easy in the future.