Bug 166472 – REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad

[Simon Fraser (smfr)]

Created attachment 297734 [details]
Patch

[Tim Horton]

Comment on attachment 297734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297734&action=review

> Source/WebCore/ChangeLog:11
> +        the "absoluteRect" passed is in actually in zoomed document coordinates for all the callers I tested.

Passed is in?

> Source/WebCore/rendering/RenderLayer.cpp:2578
> +            // Move the target rect into "scrollView contents" coordinates.

Should we have a named function to do this?

> LayoutTests/TestExpectations:54
> +# Document autoscroll tests only work on Mac WK2

:(

[Build Bot]

Comment on attachment 297734 [details]
Patch

Attachment 297734 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2778406

New failing tests:
fast/transforms/selection-bounds-in-transformed-view.html
fast/events/drag-select-when-zoomed-with-header.html

[Build Bot]

Created attachment 297735 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297734 [details]
Patch

Attachment 297734 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2778410

New failing tests:
fast/transforms/selection-bounds-in-transformed-view.html
fast/events/drag-select-when-zoomed-with-header.html

[Build Bot]

Created attachment 297736 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297734 [details]
Patch

Attachment 297734 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2778409

New failing tests:
fast/transforms/selection-bounds-in-transformed-view.html
fast/events/drag-select-when-zoomed-with-header.html

[Build Bot]

Created attachment 297737 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297734 [details]
Patch

Attachment 297734 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2778418

New failing tests:
fast/events/drag-select-when-zoomed.html
fast/events/drag-select-when-zoomed-with-header.html
fast/scrolling/scroll-to-anchor-zoomed-header.html

[Build Bot]

Created attachment 297738 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Simon Fraser (smfr)]

Created attachment 297752 [details]
Patch

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/210147