Bug 166469 - REGRESSION(r209865): Crash when navigating back to some pages with compositing layers.
Summary: REGRESSION(r209865): Crash when navigating back to some pages with compositin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2016-12-23 15:02 PST by Andreas Kling
Modified: 2016-12-23 16:24 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.05 KB, patch)
2016-12-23 15:14 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2016-12-23 15:02:05 PST 
When activating the FrameView::clearBackingStores() optimization on all platforms, some crashiness was introduced.
It doesn't look like the optimization actually helps memory usage any any significant way anymore, so I think we should just get rid of it.

<rdar://problem/29109053>
Comment 1 Andreas Kling 2016-12-23 15:14:40 PST 
Created attachment 297721 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-12-23 15:20:35 PST 
Comment on attachment 297721 [details]
Patch

Why did you enable it on Mac if it wasn't a measurable gain?
Comment 3 Andreas Kling 2016-12-23 15:29:26 PST 
(In reply to comment #2)
> Comment on attachment 297721 [details]
> Patch
> 
> Why did you enable it on Mac if it wasn't a measurable gain?

For consistency, as I wrote in the original ChangeLog. I saw a chance to remove an iOS-only code path and potentially also get a win for Mac, and jumped at it. It was all seasonal wishful thinking :\
Comment 4 WebKit Commit Bot 2016-12-23 16:24:21 PST 
Comment on attachment 297721 [details]
Patch

Clearing flags on attachment: 297721

Committed r210142: <http://trac.webkit.org/changeset/210142>
Comment 5 WebKit Commit Bot 2016-12-23 16:24:25 PST 
All reviewed patches have been landed.  Closing bug.