Bug 166466 - Using Option::breakOnThrow() shouldn't crash while printing a null CodeBlock.
Summary: Using Option::breakOnThrow() shouldn't crash while printing a null CodeBlock.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-23 11:17 PST by Mark Lam
Modified: 2016-12-23 11:46 PST (History)
4 users (show)

See Also:

Attachments
proposed patch. (1.36 KB, patch)
2016-12-23 11:19 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-12-23 11:17:24 PST 
Patch coming.
Comment 1 Mark Lam 2016-12-23 11:19:38 PST 
Created attachment 297719 [details]
proposed patch.
Comment 2 Keith Miller 2016-12-23 11:21:41 PST 
Comment on attachment 297719 [details]
proposed patch.

r=me. Semi-related nit but I feel like that option should be named crash on throw.
Comment 3 WebKit Commit Bot 2016-12-23 11:46:31 PST 
Comment on attachment 297719 [details]
proposed patch.

Clearing flags on attachment: 297719

Committed r210139: <http://trac.webkit.org/changeset/210139>
Comment 4 WebKit Commit Bot 2016-12-23 11:46:34 PST 
All reviewed patches have been landed.  Closing bug.