Bug 166454 - Reduce QuickLook.h include overhead
Summary: Reduce QuickLook.h include overhead
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-22 18:35 PST by Andy Estes
Modified: 2016-12-23 10:18 PST (History)
11 users (show)

See Also:

Attachments
Patch (11.36 KB, patch)
2016-12-22 18:47 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (12.17 KB, patch)
2016-12-22 19:36 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2016-12-22 18:35:22 PST 
Reduce QuickLook.h include overhead
Comment 1 Andy Estes 2016-12-22 18:47:52 PST 
Created attachment 297700 [details]
Patch
Comment 2 Andreas Kling 2016-12-22 19:11:52 PST 
Comment on attachment 297700 [details]
Patch

rs=me once it builds everywhere
Comment 3 Andy Estes 2016-12-22 19:36:10 PST 
Created attachment 297702 [details]
Patch
Comment 4 WebKit Commit Bot 2016-12-22 20:42:36 PST 
Comment on attachment 297702 [details]
Patch

Clearing flags on attachment: 297702

Committed r210130: <http://trac.webkit.org/changeset/210130>
Comment 5 WebKit Commit Bot 2016-12-22 20:42:42 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Simon Fraser (smfr) 2016-12-23 10:03:42 PST 
This broke the El Capitan cmake build
Comment 7 Andy Estes 2016-12-23 10:18:26 PST 
(In reply to comment #6)
> This broke the El Capitan cmake build

Attempted to fix in https://trac.webkit.org/changeset/210135