Bug 166452 - reduce PassRefPtr use in WebKit2
Summary: reduce PassRefPtr use in WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-22 17:21 PST by Alex Christensen
Modified: 2016-12-27 18:49 PST (History)
6 users (show)

See Also:

Attachments
Patch (23.60 KB, patch)
2016-12-23 08:53 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (24.72 KB, patch)
2016-12-24 00:07 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (25.56 KB, patch)
2016-12-26 21:49 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-12-22 17:21:53 PST 
reduce PassRefPtr use in WebKit2
Comment 1 Alex Christensen 2016-12-23 08:53:23 PST 
Created attachment 297709 [details]
Patch
Comment 2 WebKit Commit Bot 2016-12-23 08:55:20 PST 
Attachment 297709 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:64:  'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'.  [readability/naming/protected] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2016-12-24 00:07:15 PST 
Created attachment 297739 [details]
Patch
Comment 4 WebKit Commit Bot 2016-12-24 00:10:01 PST 
Attachment 297739 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:64:  'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'.  [readability/naming/protected] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Alex Christensen 2016-12-26 21:49:27 PST 
Created attachment 297778 [details]
Patch
Comment 6 WebKit Commit Bot 2016-12-26 21:51:37 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 7 WebKit Commit Bot 2016-12-26 21:51:51 PST 
Attachment 297778 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:64:  'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'.  [readability/naming/protected] [4]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Yusuke Suzuki 2016-12-26 23:11:36 PST 
Comment on attachment 297778 [details]
Patch

r=me
Comment 9 WebKit Commit Bot 2016-12-27 18:49:08 PST 
Comment on attachment 297778 [details]
Patch

Clearing flags on attachment: 297778

Committed r210181: <http://trac.webkit.org/changeset/210181>
Comment 10 WebKit Commit Bot 2016-12-27 18:49:12 PST 
All reviewed patches have been landed.  Closing bug.