Bug 166449 - [iOS] Move QuickLook from WebCore/platform to WebCore/loader
Summary: [iOS] Move QuickLook from WebCore/platform to WebCore/loader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-22 17:11 PST by Andy Estes
Modified: 2016-12-22 18:25 PST (History)
9 users (show)

See Also:

Attachments
Patch (57.71 KB, patch)
2016-12-22 17:17 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2016-12-22 17:11:47 PST 
[iOS] Move QuickLook from WebCore/platform to WebCore/loader
Comment 1 Andy Estes 2016-12-22 17:17:37 PST 
Created attachment 297692 [details]
Patch
Comment 2 WebKit Commit Bot 2016-12-22 17:18:54 PST 
Attachment 297692 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/ios/QuickLook.mm:64:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/loader/ios/QuickLook.mm:75:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/loader/ios/QuickLook.mm:382:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/loader/ios/QuickLook.mm:383:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/loader/ios/QuickLook.mm:384:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/loader/ios/QuickLook.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
Total errors found: 6 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2016-12-22 17:20:22 PST 
Comment on attachment 297692 [details]
Patch

rs=me
Comment 4 WebKit Commit Bot 2016-12-22 18:25:12 PST 
Comment on attachment 297692 [details]
Patch

Clearing flags on attachment: 297692

Committed r210129: <http://trac.webkit.org/changeset/210129>
Comment 5 WebKit Commit Bot 2016-12-22 18:25:16 PST 
All reviewed patches have been landed.  Closing bug.