Bug 166411 - WebAssembly: The validator should not allow unused stack entries at the end of a block
Summary: WebAssembly: The validator should not allow unused stack entries at the end o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-21 21:20 PST by Keith Miller
Modified: 2016-12-22 14:20 PST (History)
5 users (show)

See Also:


Attachments
Patch (10.84 KB, patch)
2016-12-21 21:21 PST, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-12-21 21:20:04 PST
WebAssembly: The validator should not allow unused stack entries at the end of a block
Comment 1 Keith Miller 2016-12-21 21:21:04 PST
Created attachment 297647 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2016-12-22 12:25:15 PST
<rdar://problem/29791695>
Comment 3 Saam Barati 2016-12-22 12:28:49 PST
Comment on attachment 297647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297647&action=review

r=me with a comment

> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:202
> +    void dump(const Vector<ControlEntry>& controlStack, const ExpressionList* expressionStack);

Why make this change if we assume that it's always a valid pointer?
Comment 4 Keith Miller 2016-12-22 13:55:34 PST
(In reply to comment #3)
> Comment on attachment 297647 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=297647&action=review
> 
> r=me with a comment
> 
> > Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:202
> > +    void dump(const Vector<ControlEntry>& controlStack, const ExpressionList* expressionStack);
> 
> Why make this change if we assume that it's always a valid pointer?

You cannot assign a new value to a ref. It makes the code a little shorter.
Comment 5 WebKit Commit Bot 2016-12-22 14:20:25 PST
Comment on attachment 297647 [details]
Patch

Clearing flags on attachment: 297647

Committed r210111: <http://trac.webkit.org/changeset/210111>
Comment 6 WebKit Commit Bot 2016-12-22 14:20:29 PST
All reviewed patches have been landed.  Closing bug.