WebAssembly: The validator should not allow unused stack entries at the end of a block
Created attachment 297647 [details] Patch
<rdar://problem/29791695>
Comment on attachment 297647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297647&action=review r=me with a comment > Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:202 > + void dump(const Vector<ControlEntry>& controlStack, const ExpressionList* expressionStack); Why make this change if we assume that it's always a valid pointer?
(In reply to comment #3) > Comment on attachment 297647 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=297647&action=review > > r=me with a comment > > > Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:202 > > + void dump(const Vector<ControlEntry>& controlStack, const ExpressionList* expressionStack); > > Why make this change if we assume that it's always a valid pointer? You cannot assign a new value to a ref. It makes the code a little shorter.
Comment on attachment 297647 [details] Patch Clearing flags on attachment: 297647 Committed r210111: <http://trac.webkit.org/changeset/210111>
All reviewed patches have been landed. Closing bug.