Bug 166401 - [Cocoa] SPI for setloadsImagesAutomatically
Summary: [Cocoa] SPI for setloadsImagesAutomatically
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-21 17:23 PST by Zach Li
Modified: 2016-12-22 11:50 PST (History)
4 users (show)

See Also:


Attachments
Patch (4.83 KB, patch)
2016-12-21 17:40 PST, Zach Li
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zach Li 2016-12-21 17:23:08 PST
Cocoa SPI for setloadsImagesAutomatically.
Comment 1 Zach Li 2016-12-21 17:40:19 PST
Created attachment 297642 [details]
Patch
Comment 2 Alex Christensen 2016-12-22 11:27:33 PST
Comment on attachment 297642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297642&action=review

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:51
> +    [preferences _setLoadsImagesAutomatically:NO];
> +    EXPECT_FALSE([preferences _loadsImagesAutomatically]);

This doesn't test the actual functionality of the preference.
Comment 3 WebKit Commit Bot 2016-12-22 11:50:20 PST
Comment on attachment 297642 [details]
Patch

Clearing flags on attachment: 297642

Committed r210103: <http://trac.webkit.org/changeset/210103>
Comment 4 WebKit Commit Bot 2016-12-22 11:50:24 PST
All reviewed patches have been landed.  Closing bug.