Bug 166400 - WebAssembly: Fix decode floating point constants in unreachable code
Summary: WebAssembly: Fix decode floating point constants in unreachable code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-21 17:11 PST by Keith Miller
Modified: 2016-12-21 21:03 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.97 KB, patch)
2016-12-21 17:12 PST, Keith Miller 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-12-21 17:11:15 PST 
WebAssembly: Fix decode floating point constants in unreachable code
Comment 1 Keith Miller 2016-12-21 17:12:06 PST 
Created attachment 297635 [details]
Patch
Comment 2 JF Bastien 2016-12-21 17:15:45 PST 
Comment on attachment 297635 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297635&action=review

lgtm

> Source/JavaScriptCore/ChangeLog:8
> +        We decoded these as variable length but they should be fixed length.

Can you specify which test hits this? Does it now pass?
Comment 3 Saam Barati 2016-12-21 17:19:14 PST 
Comment on attachment 297635 [details]
Patch

r=me
Please unskip the spec tests that now pass.
Comment 4 Keith Miller 2016-12-21 17:26:54 PST 
Committed r210091: <http://trac.webkit.org/changeset/210091>
Comment 5 Radar WebKit Bug Importer 2016-12-21 21:03:44 PST 
<rdar://problem/29782833>