RESOLVED FIXED 166395
WebAssembly: Import spec tests 
https://bugs.webkit.org/show_bug.cgi?id=166395
Summary WebAssembly: Import spec tests
Saam Barati
Reported 2016-12-21 14:49:13 PST
Patch coming soon
Attachments
patch (1.96 MB, patch)
2016-12-21 16:26 PST, Saam Barati 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-12-21 16:26:40 PST
Created attachment 297629 [details] patch
Keith Miller
Comment 2 2016-12-21 16:32:00 PST
Comment on attachment 297629 [details] patch rs=me.
JF Bastien
Comment 3 2016-12-21 16:34:54 PST
Comment on attachment 297629 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=297629&action=review lgtm after a few nits > JSTests/ChangeLog:12 > + them to JS, I use a script the wabt library, found here: "from" > JSTests/ChangeLog:18 > + new tests easy in the future. Can you add both repo's hashes as of this import? > JSTests/wasm.yaml:32 > +- path: wasm/spec-tests/address.wast.js Can you add a FIXME to fix all spec tests? Eventually all of these should be ":normal" right? > JSTests/wasm/import-spec-tests.rb:38 > + puts "import-spec-tests.rb --spec <path-to-wasm-spec-git-repo> --wabt <path-to-wabt-git-repo> [-v]" You should have their clone URLs here. > JSTests/wasm/import-spec-tests.rb:86 > + puts "Skipping making test for file: #{wast} because a wabt error" " of a wabt error" Or: "I hate wittle gway wabbits!"
Saam Barati
Comment 4 2016-12-21 16:59:03 PST
landed in: https://trac.webkit.org/changeset/210087
Note You need to log in before you can comment on or make changes to this bug.