Bug 166395 - WebAssembly: Import spec tests
Summary: WebAssembly: Import spec tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-21 14:49 PST by Saam Barati
Modified: 2016-12-28 21:58 PST (History)
11 users (show)

See Also:

Attachments
patch (1.96 MB, patch)
2016-12-21 16:26 PST, Saam Barati 		keith_miller: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-12-21 14:49:13 PST 
Patch coming soon
Comment 1 Saam Barati 2016-12-21 16:26:40 PST 
Created attachment 297629 [details]
patch
Comment 2 Keith Miller 2016-12-21 16:32:00 PST 
Comment on attachment 297629 [details]
patch

rs=me.
Comment 3 JF Bastien 2016-12-21 16:34:54 PST 
Comment on attachment 297629 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297629&action=review

lgtm after a few nits

> JSTests/ChangeLog:12
> +        them to JS, I use a script the wabt library, found here:

"from"

> JSTests/ChangeLog:18
> +        new tests easy in the future.

Can you add both repo's hashes as of this import?

> JSTests/wasm.yaml:32
> +- path: wasm/spec-tests/address.wast.js

Can you add a FIXME to fix all spec tests? Eventually all of these should be ":normal" right?

> JSTests/wasm/import-spec-tests.rb:38
> +    puts "import-spec-tests.rb --spec <path-to-wasm-spec-git-repo> --wabt <path-to-wabt-git-repo> [-v]"

You should have their clone URLs here.

> JSTests/wasm/import-spec-tests.rb:86
> +        puts "Skipping making test for file: #{wast} because a wabt error"

" of a wabt error"

Or: "I hate wittle gway wabbits!"
Comment 4 Saam Barati 2016-12-21 16:59:03 PST 
landed in:
https://trac.webkit.org/changeset/210087