Bug 166356 - WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
Summary: WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-21 11:28 PST by Daniel Bates
Modified: 2019-05-02 16:17 PDT (History)
5 users (show)

See Also:


Attachments
Patch - add comment (5.40 KB, patch)
2016-12-21 11:33 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-12-21 11:28:41 PST
The remark in the patch for bug #43389 makes it unclear whether we should remove the test plugins/get-url-with-blank-target.html. Should we feel this test has value and want to keep it then we will need to implement testRunner.setCanOpenWindows() in WebKitTestRunner such that WebKitTestRunner forbids opening windows by default (this matches the behavior in DumpRenderTree). We should update the comment in TestRunner::setCanOpenWindows() to explain its purpose should we decide to keep the test plugins/get-url-with-blank-target.html.
Comment 1 Daniel Bates 2016-12-21 11:33:45 PST
Created attachment 297610 [details]
Patch - add comment
Comment 2 Daniel Bates 2016-12-21 11:36:42 PST
Committed r210070: <http://trac.webkit.org/changeset/210070>