Bug 166346 - [WebRTC] Add support for runtime PeerConnection setting, required after r209757
Summary: [WebRTC] Add support for runtime PeerConnection setting, required after r209757
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alejandro G. Castro
URL:
Keywords:
Depends on: 165251
Blocks:
  Show dependency tree / graph
 
Reported: 2016-12-21 10:27 PST by Alejandro G. Castro
Modified: 2016-12-22 01:23 PST (History)
10 users (show)

See Also:

Attachments
Patch (2.92 KB, patch)
2016-12-21 10:46 PST, Alejandro G. Castro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2016-12-21 10:27:27 PST 
After that commit webrtc is controlled using a runtime flags, we are going to enable by default and use the same gUM setting for both things in our case.
Comment 1 Alejandro G. Castro 2016-12-21 10:46:24 PST 
Created attachment 297604 [details]
Patch
Comment 2 WebKit Commit Bot 2016-12-21 10:48:39 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2016-12-22 00:44:42 PST 
Comment on attachment 297604 [details]
Patch

Ok, I guess it makes sense to reuse the media stream setting for now.
Comment 4 WebKit Commit Bot 2016-12-22 01:23:26 PST 
Comment on attachment 297604 [details]
Patch

Clearing flags on attachment: 297604

Committed r210096: <http://trac.webkit.org/changeset/210096>
Comment 5 WebKit Commit Bot 2016-12-22 01:23:30 PST 
All reviewed patches have been landed.  Closing bug.