Bug 166312 – [Readable Streams API] Fix test in readableByteStreamCallPullIfNeeded

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Romain Bellessort]

As indicated in https://bugs.webkit.org/show_bug.cgi?id=166022#c10, the test to check whether pull should be called is not valid (this went unnoticed as implementation does not allow reaching invalid code for the moment, but it would become possible as the implementation progresses).

Therefore, the test should be rewritten to be valid and also to be more readable. A possible option may be to stick to the spec and to rely on a dedicated readableByteStreamShouldCallPull function.

[Nael Ouedraogo]

Created attachment 297587 [details]
Patch

[Build Bot]

Comment on attachment 297587 [details]
Patch

Attachment 297587 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2765047

New failing tests:
compositing/absolute-inside-out-of-view-fixed.html

[Build Bot]

Created attachment 297588 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Nael Ouedraogo]

(In reply to comment #2)
> Comment on attachment 297587 [details]
> Patch
> 
> Attachment 297587 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/2765047
> 
> New failing tests:
> compositing/absolute-inside-out-of-view-fixed.html
Failure observed on compositing/absolute-inside-out-of-view-fixed.html on ios-simulator-wk2 seems not related to the patch.

[Nael Ouedraogo]

Thanks for the review.

[WebKit Commit Bot]

Comment on attachment 297587 [details]
Patch

Clearing flags on attachment: 297587

Committed r210060: <http://trac.webkit.org/changeset/210060>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.