Bug 166298 - WebKitTestRunner: Enable popup blocking by default and toggling testRunner.setPopupBlocking() should affect all windows
Summary: WebKitTestRunner: Enable popup blocking by default and toggling testRunner.se...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-20 17:14 PST by Daniel Bates
Modified: 2016-12-20 18:40 PST (History)
5 users (show)

See Also:

Attachments
Patch and unskip some tests (11.93 KB, patch)
2016-12-20 17:28 PST, Daniel Bates 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.52 MB, application/zip)
2016-12-20 17:58 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-12-20 17:14:15 PST 
We should enable popup-blocking by default and toggling testRunner.setPopupBlocking() should affect all windows in WebKitTestRunner so as to match the behavior in DumpRenderTree. Making the former change will allow us to unskip the tests http/tests/security/popup-blocked-from-{fake-event, window-open}.html for WebKit2.

For completeness, popup-blocking was enabled by default ((-[WebPreferences setJavaScriptCanOpenWindowsAutomatically:YES]) in DumpRenderTree in <https://trac.webkit.org/changeset/20742>.
Comment 1 Daniel Bates 2016-12-20 17:28:14 PST 
Created attachment 297573 [details]
Patch and unskip some tests
Comment 2 Build Bot 2016-12-20 17:58:32 PST 
Comment on attachment 297573 [details]
Patch and unskip some tests

Attachment 297573 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2762141

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2016-12-20 17:58:35 PST 
Created attachment 297575 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 4 Daniel Bates 2016-12-20 18:40:03 PST 
Wow, not sure what I was thinking. I'm tired.