RESOLVED INVALID 166298
WebKitTestRunner: Enable popup blocking by default and toggling testRunner.setPopupBlocking() should affect all windows 
https://bugs.webkit.org/show_bug.cgi?id=166298
Summary WebKitTestRunner: Enable popup blocking by default and toggling testRunner.se...
Daniel Bates
Reported 2016-12-20 17:14:15 PST
We should enable popup-blocking by default and toggling testRunner.setPopupBlocking() should affect all windows in WebKitTestRunner so as to match the behavior in DumpRenderTree. Making the former change will allow us to unskip the tests http/tests/security/popup-blocked-from-{fake-event, window-open}.html for WebKit2. For completeness, popup-blocking was enabled by default ((-[WebPreferences setJavaScriptCanOpenWindowsAutomatically:YES]) in DumpRenderTree in <https://trac.webkit.org/changeset/20742>.
Attachments
Patch and unskip some tests (11.93 KB, patch)
2016-12-20 17:28 PST, Daniel Bates 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.52 MB, application/zip)
2016-12-20 17:58 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2016-12-20 17:28:14 PST
Created attachment 297573 [details] Patch and unskip some tests
Build Bot
Comment 2 2016-12-20 17:58:32 PST
Comment on attachment 297573 [details] Patch and unskip some tests Attachment 297573 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2762141 Number of test failures exceeded the failure limit.
Build Bot
Comment 3 2016-12-20 17:58:35 PST
Created attachment 297575 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Daniel Bates
Comment 4 2016-12-20 18:40:03 PST
Wow, not sure what I was thinking. I'm tired.
Note You need to log in before you can comment on or make changes to this bug.