Bug 166297 - REGRESSION (r209396): Web Inspector: Uncommenting CSS properties doesn't work for inline styles
Summary: REGRESSION (r209396): Web Inspector: Uncommenting CSS properties doesn't work...
Status: RESOLVED DUPLICATE of bug 166786
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on: 166439
Blocks:
  Show dependency tree / graph
 
Reported: 2016-12-20 17:08 PST by Nikita Vasilyev
Modified: 2017-01-06 17:04 PST (History)
4 users (show)

See Also:

Attachments
[HTML] Reduction (35 bytes, text/html)
2016-12-20 17:08 PST, Nikita Vasilyev 		no flags Details
Patch (1.42 KB, patch)
2016-12-20 17:11 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Animated GIF] With patch applied (14.68 KB, image/gif)
2016-12-20 17:19 PST, Nikita Vasilyev 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2016-12-20 17:08:32 PST 
Created attachment 297569 [details]
[HTML] Reduction

Steps:
1. Open attached reduction.
2. Inspect "Paragraph".
3. In the Styles sidebar, click on the checkbox to comment out "color: red" rule.
4. Click on this checkbox again.

Expected:
Uncommented rule, e.g. "color: red".

Actual:
Doubly commented rule, e.g. "/* /* color: red */ */".
Comment 1 Nikita Vasilyev 2016-12-20 17:11:09 PST 
Created attachment 297570 [details]
Patch
Comment 2 Nikita Vasilyev 2016-12-20 17:19:06 PST 
Created attachment 297572 [details]
[Animated GIF] With patch applied

Before the patch: https://bug-165831-attachments.webkit.org/attachment.cgi?id=297480
Comment 3 Radar WebKit Bug Importer 2016-12-20 23:30:33 PST 
<rdar://problem/29767412>
Comment 4 BJ Burg 2016-12-21 10:47:50 PST 
Comment on attachment 297570 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2016-12-21 11:14:15 PST 
Comment on attachment 297570 [details]
Patch

Clearing flags on attachment: 297570

Committed r210069: <http://trac.webkit.org/changeset/210069>
Comment 6 WebKit Commit Bot 2016-12-21 11:14:20 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Nikita Vasilyev 2016-12-21 17:16:31 PST 
The new CSS parser somehow broke this.
https://trac.webkit.org/changeset/209396/trunk
Comment 8 WebKit Commit Bot 2016-12-22 15:12:42 PST 
Re-opened since this is blocked by bug 166439
Comment 9 Nikita Vasilyev 2017-01-06 13:38:22 PST 
Before the new CSS parser, disabling a CSS property by clicking a checkbox would result in WebInspector.CSSStyleDeclaration.Event.PropertiesChanged event being fired:

    {
        addedProperties: [],
        removedProperties: [
            {
                _text: "color: red",
                _enabled: true,
                ...
            }
        ]
    }

It stopped happening with the new parser (r209396+).
Comment 10 Joseph Pecoraro 2017-01-06 17:04:08 PST 
Duping to the single bug to handle CSS Toggling issues:

*** This bug has been marked as a duplicate of bug 166786 ***