Bug 166294 – Web Inspector: Fix Content Flow Container Regions Computed Style section

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
Fix Content Flow Computed Style section

These LayoutTests were consistently failing, but only noticeable if you --force because they are marked [Pass Timeout]:
LayoutTests/inspector/dom/content-flow-list.html
LayoutTests/inspector/dom/content-node-region-info.html

One looks like a testing issue (domTree is not updated across navigation).
The other looks like a legit issue that can be addressed.

Steps to Reproduce:
1. Inspect div#flow on LayoutTests/inspector/dom/content-node-region-info.html
2. Show Styles > Computed Styles sidebar
  => Expected Container Regions section for the regions it flows into

[Joseph Pecoraro]

Created attachment 297562 [details]
[PATCH] Proposed Fix

[Blaze Burg]

Comment on attachment 297562 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=297562&action=review

r=me

> LayoutTests/ChangeLog:8
> +        * inspector/dom/content-flow-list.html:

Should we try to unskip this test now?

> Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:663
> +                functionDeclaration: appendWebInspectorSourceURL(inspectedPage_node_getFlowInfo.toString()),

I like this name. I updated the style guide to document this convention.

[Joseph Pecoraro]

(In reply to comment #2)
> Comment on attachment 297562 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=297562&action=review
> 
> r=me
> 
> > LayoutTests/ChangeLog:8
> > +        * inspector/dom/content-flow-list.html:
> 
> Should we try to unskip this test now?

I'll leave this up to you as you start investigating the tests. It should be okay but we had "random failures" in the past which wouldn't account for these deterministic failures.

[Joseph Pecoraro]

https://trac.webkit.org/changeset/210250