Bug 16629 - <canvas> does not support isPointInPath()
Summary: <canvas> does not support isPointInPath()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.4
: P2 Enhancement
Assignee: Oliver Hunt
URL: http://www.whatwg.org/specs/web-apps/...
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-27 23:15 PST by Eric Seidel
Modified: 2008-01-27 23:06 PST (History)
1 user (show)

See Also:


Attachments
Add support for isPointInPath (10.68 KB, patch)
2008-01-27 20:54 PST, Oliver Hunt
sam: review-
Details | Formatted Diff | Diff
Appease sam, yet more testcases! (12.18 KB, patch)
2008-01-27 22:54 PST, Oliver Hunt
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel 2007-12-27 23:15:32 PST
<canvas> does not support isPointInPath()

This is a Mozilla extension to <canvas> which HTML5 seems to have picked up:
http://www.whatwg.org/specs/web-apps/current-work/#ispointinpath
Comment 1 Oliver Hunt 2008-01-27 20:54:26 PST
Created attachment 18732 [details]
Add support for isPointInPath
Comment 2 Sam Weinig 2008-01-27 22:14:09 PST
Comment on attachment 18732 [details]
Add support for isPointInPath

I am going to tentatively r- this because I believe you need to account for the case when the transform is non-invertable and there should be an accompanying test case.
Comment 3 Oliver Hunt 2008-01-27 22:54:49 PST
Created attachment 18733 [details]
Appease sam, yet more testcases!
Comment 4 Oliver Hunt 2008-01-27 22:56:09 PST
I have corrected the tyop in the test case s/invertible/non-invertible
Comment 5 Sam Weinig 2008-01-27 22:58:44 PST
Comment on attachment 18733 [details]
Appease sam, yet more testcases!

Looks good.  You are missing a new line and the test case could use a description() like many of the others.
Comment 6 Oliver Hunt 2008-01-27 23:06:40 PST
Landed in r29827