RESOLVED FIXED 166061
RenderFlexibleBox::applyStretchAlignmentToChild uses wrong available width for constrainLogicalWidthInRegionByMinMax 
https://bugs.webkit.org/show_bug.cgi?id=166061
Summary RenderFlexibleBox::applyStretchAlignmentToChild uses wrong available width fo...
Christian Biesinger
Reported 2016-12-20 07:07:05 PST
From Chrome bug https://bugs.chromium.org/p/chromium/issues/detail?id=675333 The code here: https://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp#L1499 childWidth = child.constrainLogicalWidthInRegionByMinMax(childWidth, childWidth, *this); Should not pass childWidth() as the second argument -- that will lead to an incorrect percentage calculation for multiline column flexboxes or children with margins in a column flexbox. See the mentioned Chrome bug for a testcase. Fix should be to replace the second childWidth with contentLogicalWidth().
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-12-21 17:29:11 PST
<rdar://problem/29780895>
Kyle Bishop
Comment 2 2017-02-06 22:42:43 PST
This is a confirmed bug in Chrome with a known and easy fix. Bumping this to request an easy patch because this bug affects a number of CSS/JS layout frameworks, and causes more harm the longer the bug lingers. Thanks!
Dave Hyatt
Comment 3 2017-02-28 10:48:09 PST
This was fixed (and atest case added) by my Blink merge to flex box.
Note You need to log in before you can comment on or make changes to this bug.