Bug 166040 - Fix unwanted deletion of record/replay files
Summary: Fix unwanted deletion of record/replay files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-19 14:56 PST by Keith Rollin
Modified: 2016-12-19 16:37 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.45 KB, patch)
2016-12-19 14:59 PST, Keith Rollin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2016-12-19 14:56:00 PST 
As part of some refactoring, the objects that create the meta files that are part of the record/replay cache would get deleted. They were always getting opened in "write" mode", which would truncate the files. Fix this so that the files are opened in the write modes for record, replay, and neither.
Comment 1 Keith Rollin 2016-12-19 14:58:08 PST 
That is, the "right" modes, not the "write" modes.
Comment 2 Keith Rollin 2016-12-19 14:59:00 PST 
Created attachment 297481 [details]
Patch
Comment 3 Alex Christensen 2016-12-19 15:05:02 PST 
Comment on attachment 297481 [details]
Patch

r=me.
Since the m_loadFileHandle and m_replayFileHandle are used only for logging when replaying, do you think it would be good to have "Log" somewhere in their name?
Comment 4 Keith Rollin 2016-12-19 15:43:42 PST 
I'll file a new bug for that, since naming things is one of the Big Unsolved Problems in Computer Science.
Comment 5 WebKit Commit Bot 2016-12-19 16:37:42 PST 
Comment on attachment 297481 [details]
Patch

Clearing flags on attachment: 297481

Committed r210005: <http://trac.webkit.org/changeset/210005>
Comment 6 WebKit Commit Bot 2016-12-19 16:37:45 PST 
All reviewed patches have been landed.  Closing bug.