Bug 166038 - LayoutTest http/tests/inspector/network/fetch-network-data.html is a flaky timeout
Summary: LayoutTest http/tests/inspector/network/fetch-network-data.html is a flaky ti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 164033 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-12-19 14:27 PST by Ryan Haddad
Modified: 2017-05-03 15:30 PDT (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (2.54 KB, patch)
2017-05-03 14:34 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (5.12 KB, patch)
2017-05-03 14:54 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Ryan Haddad 2016-12-19 14:28:47 PST
This test was added with https://trac.webkit.org/changeset/209734, and appears to have been flaky from the start.
Comment 2 Ryan Haddad 2016-12-19 15:37:45 PST
Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/209999
Comment 3 Joseph Pecoraro 2017-05-03 14:34:32 PDT
Created attachment 308955 [details]
[PATCH] Proposed Fix

With this change I'm able to `run-webkit-tests http/tests/inspector/network --iterations=40 --force` without errors. Previously this test was failing approximately the second iteration onwards (when the response comes from the disk cache).
Comment 4 Joseph Pecoraro 2017-05-03 14:50:03 PDT
Comment on attachment 308955 [details]
[PATCH] Proposed Fix

Clearing review flag. There is another test that would benefit from the same change.
Comment 5 Matt Baker 2017-05-03 14:52:06 PDT
With --iterations=100 I get:

[791/1800] http/tests/inspector/network/xhr-request-data-encoded-correctly.html failed unexpectedly (test timed out, text diff)
[1025/1800] http/tests/inspector/network/xhr-request-data-encoded-correctly.html failed unexpectedly (test timed out, text diff)
Comment 6 Joseph Pecoraro 2017-05-03 14:54:42 PDT
Created attachment 308959 [details]
[PATCH] Proposed Fix
Comment 7 Joseph Pecoraro 2017-05-03 14:55:15 PDT
<rdar://problem/29488489>
Comment 8 Joseph Pecoraro 2017-05-03 14:55:41 PDT
*** Bug 164033 has been marked as a duplicate of this bug. ***
Comment 9 Matt Baker 2017-05-03 15:00:18 PDT
Comment on attachment 308959 [details]
[PATCH] Proposed Fix

r=me

Passed with --iterations=100
Comment 10 WebKit Commit Bot 2017-05-03 15:30:41 PDT
Comment on attachment 308959 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 308959

Committed r216150: <http://trac.webkit.org/changeset/216150>
Comment 11 WebKit Commit Bot 2017-05-03 15:30:43 PDT
All reviewed patches have been landed.  Closing bug.