WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
166038
LayoutTest http/tests/inspector/network/fetch-network-data.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=166038
Summary
LayoutTest http/tests/inspector/network/fetch-network-data.html is a flaky ti...
Ryan Haddad
Reported
2016-12-19 14:27:35 PST
LayoutTest http/tests/inspector/network/fetch-network-data.html is a flaky timeout
https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r209990%20(1428)/results.html
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fnetwork%2Ffetch-network-data.html
Attachments
[PATCH] Proposed Fix
(2.54 KB, patch)
2017-05-03 14:34 PDT
,
Joseph Pecoraro
no flags
Details
Formatted Diff
Diff
[PATCH] Proposed Fix
(5.12 KB, patch)
2017-05-03 14:54 PDT
,
Joseph Pecoraro
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ryan Haddad
Comment 1
2016-12-19 14:28:47 PST
This test was added with
https://trac.webkit.org/changeset/209734
, and appears to have been flaky from the start.
Ryan Haddad
Comment 2
2016-12-19 15:37:45 PST
Marked test as flaky in
http://trac.webkit.org/projects/webkit/changeset/209999
Joseph Pecoraro
Comment 3
2017-05-03 14:34:32 PDT
Created
attachment 308955
[details]
[PATCH] Proposed Fix With this change I'm able to `run-webkit-tests http/tests/inspector/network --iterations=40 --force` without errors. Previously this test was failing approximately the second iteration onwards (when the response comes from the disk cache).
Joseph Pecoraro
Comment 4
2017-05-03 14:50:03 PDT
Comment on
attachment 308955
[details]
[PATCH] Proposed Fix Clearing review flag. There is another test that would benefit from the same change.
Matt Baker
Comment 5
2017-05-03 14:52:06 PDT
With --iterations=100 I get: [791/1800] http/tests/inspector/network/xhr-request-data-encoded-correctly.html failed unexpectedly (test timed out, text diff) [1025/1800] http/tests/inspector/network/xhr-request-data-encoded-correctly.html failed unexpectedly (test timed out, text diff)
Joseph Pecoraro
Comment 6
2017-05-03 14:54:42 PDT
Created
attachment 308959
[details]
[PATCH] Proposed Fix
Joseph Pecoraro
Comment 7
2017-05-03 14:55:15 PDT
<
rdar://problem/29488489
>
Joseph Pecoraro
Comment 8
2017-05-03 14:55:41 PDT
***
Bug 164033
has been marked as a duplicate of this bug. ***
Matt Baker
Comment 9
2017-05-03 15:00:18 PDT
Comment on
attachment 308959
[details]
[PATCH] Proposed Fix r=me Passed with --iterations=100
WebKit Commit Bot
Comment 10
2017-05-03 15:30:41 PDT
Comment on
attachment 308959
[details]
[PATCH] Proposed Fix Clearing flags on attachment: 308959 Committed
r216150
: <
http://trac.webkit.org/changeset/216150
>
WebKit Commit Bot
Comment 11
2017-05-03 15:30:43 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug