Bug 165989 - WebAssembly: WasmB3IRGenerator uses WarmAny as a ValueRep but expects the incoming value to be a register
Summary: WebAssembly: WasmB3IRGenerator uses WarmAny as a ValueRep but expects the inc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-16 23:20 PST by Saam Barati
Modified: 2016-12-17 10:45 PST (History)
12 users (show)

See Also:


Attachments
patch (2.08 KB, patch)
2016-12-16 23:26 PST, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-12-16 23:20:12 PST
This is obviously wrong. B3 could pass in a stack value rep.
Comment 1 Saam Barati 2016-12-16 23:26:15 PST
Created attachment 297393 [details]
patch
Comment 2 Mark Lam 2016-12-17 08:55:33 PST
Comment on attachment 297393 [details]
patch

r=me
Comment 3 WebKit Commit Bot 2016-12-17 10:44:55 PST
Comment on attachment 297393 [details]
patch

Clearing flags on attachment: 297393

Committed r209966: <http://trac.webkit.org/changeset/209966>
Comment 4 WebKit Commit Bot 2016-12-17 10:45:00 PST
All reviewed patches have been landed.  Closing bug.