Seems ASSERT_GC_OBJECT_LOOKS_VALID is causing a warning again (like in r194303). Ways to fix this: * Use ASSERT_THIS_GC_OBJECT_INHERITS instead of ASSERT_GC_OBJECT_INHERITS. The only difference is ASSERT_THIS_GC_OBJECT_INHERITS doesn't have the null check that triggers the warning, so the behavior is what we want, but it'd be evil because here we are checking |thisObject| which is a normal parameter, not |this|. * Add more macros that do the same thing, with different names. * Just pass the original pointer rather than taking the address of a reference. If this starts happening in more cases we should probably go with the second option, but the last option seems cleanest for now. [1244/4409] Building CXX object Source...bindings/js/JSHTMLDocumentCustom.cpp.o In file included from ../../Source/WTF/wtf/StdLibExtras.h:33:0, from ../../Source/WTF/wtf/FastMalloc.h:26, from ../../Source/WebCore/config.h:75, from ../../Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:26: ../../Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp: In static member function ‘static bool WebCore::JSHTMLDocument::getOwnPropertySlot(JSC::JSObject*, JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&)’: ../../Source/WTF/wtf/Assertions.h:283:20: warning: the compiler can assume that the address of ‘thisObject’ will always evaluate to ‘true’ [-Waddress] if (!(assertion)) { \ ^ ../../Source/WTF/wtf/Assertions.h:437:35: note: in expansion of macro ‘ASSERT’ #define RELEASE_ASSERT(assertion) ASSERT(assertion) ^~~~~~ ../../Source/JavaScriptCore/heap/GCAssertions.h:34:5: note: in expansion of macro ‘RELEASE_ASSERT’ RELEASE_ASSERT(cell);\ ^~~~~~~~~~~~~~ ../../Source/JavaScriptCore/heap/GCAssertions.h:39:5: note: in expansion of macro ‘ASSERT_GC_OBJECT_LOOKS_VALID’ ASSERT_GC_OBJECT_LOOKS_VALID(object); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:58:5: note: in expansion of macro ‘ASSERT_GC_OBJECT_INHERITS’ ASSERT_GC_OBJECT_INHERITS((&thisObject), info()); ^ ../../Source/WTF/wtf/Assertions.h:283:20: warning: the compiler can assume that the address of ‘thisObject’ will always evaluate to ‘true’ [-Waddress] if (!(assertion)) { \ ^ ../../Source/WTF/wtf/Assertions.h:437:35: note: in expansion of macro ‘ASSERT’ #define RELEASE_ASSERT(assertion) ASSERT(assertion) ^~~~~~ ../../Source/JavaScriptCore/heap/GCAssertions.h:34:5: note: in expansion of macro ‘RELEASE_ASSERT’ RELEASE_ASSERT(cell);\ ^~~~~~~~~~~~~~ ../../Source/JavaScriptCore/heap/GCAssertions.h:39:5: note: in expansion of macro ‘ASSERT_GC_OBJECT_LOOKS_VALID’ ASSERT_GC_OBJECT_LOOKS_VALID(object); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:58:5: note: in expansion of macro ‘ASSERT_GC_OBJECT_INHERITS’ ASSERT_GC_OBJECT_INHERITS((&thisObject), info()); ^
Created attachment 297404 [details] Patch
Comment on attachment 297404 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297404&action=review r=me > Source/WebCore/ChangeLog:3 > + warning: the compiler can assume that the address of âthisObjectâ will always evaluate to âtrueâ [-Waddress] in WebCore::JSHTMLDocument::getOwnPropertySlot please fix non-ascii chars.
Committed r209965: <http://trac.webkit.org/changeset/209965>