Bug 165983 - Visual viewports: bottom fixed elements disappear behind the keyboard
Summary: Visual viewports: bottom fixed elements disappear behind the keyboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-16 18:54 PST by Wenson Hsieh
Modified: 2016-12-18 00:12 PST (History)
4 users (show)

See Also:


Attachments
Patch (63.92 KB, patch)
2016-12-16 20:35 PST, Wenson Hsieh
simon.fraser: review+
Details | Formatted Diff | Diff
Patch for landing (64.35 KB, patch)
2016-12-17 10:41 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Fix iOS testing. (8.91 KB, patch)
2016-12-17 23:45 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2016-12-16 18:54:50 PST
0. Enable visual viewports when focusing assisted nodes
1. Go to whsieh.github.io/examples/fixed-inputs
2. Focus the bottom <input>

Observed: bottom <input> is obscured behind the keyboard.
Comment 1 Wenson Hsieh 2016-12-16 20:35:16 PST
Created attachment 297390 [details]
Patch
Comment 2 Wenson Hsieh 2016-12-16 20:36:19 PST
<rdar://problem/29409852>
Comment 3 WebKit Commit Bot 2016-12-16 20:37:01 PST
Attachment 297390 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:54:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 1 in 47 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Wenson Hsieh 2016-12-17 10:41:20 PST
Thanks Simon! Looks like there's one more test I need to rebaseline (fast/viewport/ios/width-is-device-width-expected.txt). I'll do that before landing.
Comment 5 Wenson Hsieh 2016-12-17 10:41:55 PST
Created attachment 297410 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2016-12-17 11:18:51 PST
Comment on attachment 297410 [details]
Patch for landing

Clearing flags on attachment: 297410

Committed r209967: <http://trac.webkit.org/changeset/209967>
Comment 7 Simon Fraser (smfr) 2016-12-17 23:20:30 PST
This caused hundreds of compositing failures for iso-simulator:
https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/r209967%20(2310)/results.html
Comment 8 Simon Fraser (smfr) 2016-12-17 23:45:44 PST
Reopening to attach new patch.
Comment 9 Simon Fraser (smfr) 2016-12-17 23:45:46 PST
Created attachment 297426 [details]
Fix iOS testing.
Comment 10 WebKit Commit Bot 2016-12-17 23:48:04 PST
Attachment 297426 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Simon Fraser (smfr) 2016-12-18 00:12:53 PST
WTR fix landed in https://trac.webkit.org/r209972