WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
165968
[CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
https://bugs.webkit.org/show_bug.cgi?id=165968
Summary
[CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
Dave Hyatt
Reported
2016-12-16 12:31:23 PST
[CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
Attachments
Patch
(176.25 KB, patch)
2016-12-16 12:46 PST
,
Dave Hyatt
no flags
Details
Formatted Diff
Diff
Patch
(176.24 KB, patch)
2016-12-16 12:51 PST
,
Dave Hyatt
no flags
Details
Formatted Diff
Diff
Patch
(176.57 KB, patch)
2016-12-16 13:30 PST
,
Dave Hyatt
no flags
Details
Formatted Diff
Diff
Patch
(181.73 KB, patch)
2016-12-16 13:46 PST
,
Dave Hyatt
kling
: review+
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Dave Hyatt
Comment 1
2016-12-16 12:46:23 PST
Created
attachment 297345
[details]
Patch
Dave Hyatt
Comment 2
2016-12-16 12:51:30 PST
Created
attachment 297346
[details]
Patch
WebKit Commit Bot
Comment 3
2016-12-16 12:52:59 PST
Attachment 297346
[details]
did not pass style-queue: ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:41: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:42: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:44: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:45: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:46: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:47: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:48: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:49: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:50: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:51: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:52: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:53: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:54: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:55: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:56: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:57: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:58: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:59: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:60: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:61: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:62: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:63: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:64: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:65: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:66: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:67: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:68: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:69: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:70: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:44: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:45: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:46: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 34 in 57 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 4
2016-12-16 13:30:16 PST
Created
attachment 297351
[details]
Patch
WebKit Commit Bot
Comment 5
2016-12-16 13:33:19 PST
Attachment 297351
[details]
did not pass style-queue: ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:41: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:42: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:44: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:45: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:46: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:47: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:48: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:49: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:50: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:51: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:52: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:53: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:54: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:55: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:56: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:57: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:58: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:59: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:60: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:61: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:62: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:63: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:64: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:65: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:66: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:67: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:68: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:69: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:70: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:44: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:45: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:46: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 34 in 57 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 6
2016-12-16 13:46:54 PST
Created
attachment 297352
[details]
Patch
WebKit Commit Bot
Comment 7
2016-12-16 13:48:46 PST
Attachment 297352
[details]
did not pass style-queue: ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:41: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:42: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:44: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:45: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:46: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:47: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:48: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:49: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:50: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:51: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:52: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:53: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:54: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:55: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:56: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:57: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:58: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:59: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:60: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:61: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:62: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:63: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:64: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:65: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:66: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:67: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:68: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:69: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:70: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCSSValuePrivate.h" WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCSSValue.cpp" ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:44: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:45: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:46: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 34 in 60 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 8
2016-12-16 16:23:12 PST
Comment on
attachment 297352
[details]
Patch Awesome! r=me
Simon Fraser (smfr)
Comment 9
2016-12-18 00:13:44 PST
Link error fixed in
https://trac.webkit.org/r209971
Simon Fraser (smfr)
Comment 10
2016-12-18 00:14:23 PST
Main patch landed in
https://trac.webkit.org/changeset/209969
Antti Koivisto
Comment 11
2016-12-19 08:54:37 PST
Comment on
attachment 297352
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=297352&action=review
> Source/WebCore/css/DeprecatedCSSOMValue.h:86 > + // NOTE: This class is non-virtual for memory and performance reasons. > + // Don't go making it virtual again unless you know exactly what you're doing! > + ~DeprecatedCSSOMValue() { }
These could be virtual. Only the internal types are (possibly) worth this optimization.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug