Bug 165966 - Add missing cases to parseUnreachableExpression and cleanup FunctionParser
Summary: Add missing cases to parseUnreachableExpression and cleanup FunctionParser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-16 11:58 PST by Keith Miller
Modified: 2016-12-16 13:37 PST (History)
4 users (show)

See Also:

Attachments
Patch (14.67 KB, patch)
2016-12-16 12:30 PST, Keith Miller 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-12-16 11:58:46 PST 
Add missing cases to parseUnreachableExpression and cleanup FunctionParser
Comment 1 Keith Miller 2016-12-16 12:30:28 PST 
Created attachment 297342 [details]
Patch
Comment 2 WebKit Commit Bot 2016-12-16 12:32:12 PST 
Attachment 297342 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/wasm/WasmFunctionParser.h:204:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Saam Barati 2016-12-16 13:35:14 PST 
Comment on attachment 297342 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297342&action=review

> Source/JavaScriptCore/wasm/WasmFunctionParser.h:498
> +// FIXME: We should try to use the same decoder function for both unreachable and reachable code. https://bugs.webkit.org/show_bug.cgi?id=165965

Yeah :(
Comment 4 Keith Miller 2016-12-16 13:37:19 PST 
Committed r209934: <http://trac.webkit.org/changeset/209934>