RESOLVED FIXED 165966
Add missing cases to parseUnreachableExpression and cleanup FunctionParser 
https://bugs.webkit.org/show_bug.cgi?id=165966
Summary Add missing cases to parseUnreachableExpression and cleanup FunctionParser
Keith Miller
Reported 2016-12-16 11:58:46 PST
Add missing cases to parseUnreachableExpression and cleanup FunctionParser
Attachments
Patch (14.67 KB, patch)
2016-12-16 12:30 PST, Keith Miller 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-12-16 12:30:28 PST
Created attachment 297342 [details] Patch
WebKit Commit Bot
Comment 2 2016-12-16 12:32:12 PST
Attachment 297342 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/WasmFunctionParser.h:204: Non-label code inside switch statements should be indented. [whitespace/indent] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 3 2016-12-16 13:35:14 PST
Comment on attachment 297342 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297342&action=review > Source/JavaScriptCore/wasm/WasmFunctionParser.h:498 > +// FIXME: We should try to use the same decoder function for both unreachable and reachable code. https://bugs.webkit.org/show_bug.cgi?id=165965 Yeah :(
Keith Miller
Comment 4 2016-12-16 13:37:19 PST
Committed r209934: <http://trac.webkit.org/changeset/209934>
Note You need to log in before you can comment on or make changes to this bug.