Bug 165960 – HTML form validation bubble should be dismissed on navigation

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

HTML form validation bubble should be dismissed on navigation.

[Chris Dumez]

<rdar://problem/29668086>

[Chris Dumez]

Created attachment 297338 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 297338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297338&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:3174
> +        hideValidationMessage();

Is this the right place? This happens before the rest of the page changes (which is didCommitLoad or later).

> LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles.html:15
> +    }, 100);

100ms is a pretty long test.

[Chris Dumez]

Comment on attachment 297338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297338&action=review

>> Source/WebKit2/UIProcess/WebPageProxy.cpp:3174
>> +        hideValidationMessage();
> 
> Is this the right place? This happens before the rest of the page changes (which is didCommitLoad or later).

Yes, this happens early in the load but I figured that there is no point showing the bubble if a navigation has been triggered, even if that load has not been committed yet.

>> LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles.html:15
>> +    }, 100);
> 
> 100ms is a pretty long test.

Ok, I can shorten this before landing.

[Chris Dumez]

Created attachment 297353 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 297353 [details]
Patch

Clearing flags on attachment: 297353

Committed r209941: <http://trac.webkit.org/changeset/209941>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.