Bug 165960 - HTML form validation bubble should be dismissed on navigation
Summary: HTML form validation bubble should be dismissed on navigation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-16 10:56 PST by Chris Dumez
Modified: 2016-12-16 15:01 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.33 KB, patch)
2016-12-16 11:56 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (6.41 KB, patch)
2016-12-16 13:54 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-12-16 10:56:39 PST 
HTML form validation bubble should be dismissed on navigation.
Comment 1 Chris Dumez 2016-12-16 10:57:04 PST 
<rdar://problem/29668086>
Comment 2 Chris Dumez 2016-12-16 11:56:13 PST 
Created attachment 297338 [details]
Patch
Comment 3 Simon Fraser (smfr) 2016-12-16 13:10:01 PST 
Comment on attachment 297338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297338&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:3174
> +        hideValidationMessage();

Is this the right place? This happens before the rest of the page changes (which is didCommitLoad or later).

> LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles.html:15
> +    }, 100);

100ms is a pretty long test.
Comment 4 Chris Dumez 2016-12-16 13:11:56 PST 
Comment on attachment 297338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297338&action=review

>> Source/WebKit2/UIProcess/WebPageProxy.cpp:3174
>> +        hideValidationMessage();
> 
> Is this the right place? This happens before the rest of the page changes (which is didCommitLoad or later).

Yes, this happens early in the load but I figured that there is no point showing the bubble if a navigation has been triggered, even if that load has not been committed yet.

>> LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles.html:15
>> +    }, 100);
> 
> 100ms is a pretty long test.

Ok, I can shorten this before landing.
Comment 5 Chris Dumez 2016-12-16 13:54:53 PST 
Created attachment 297353 [details]
Patch
Comment 6 WebKit Commit Bot 2016-12-16 15:01:26 PST 
Comment on attachment 297353 [details]
Patch

Clearing flags on attachment: 297353

Committed r209941: <http://trac.webkit.org/changeset/209941>
Comment 7 WebKit Commit Bot 2016-12-16 15:01:30 PST 
All reviewed patches have been landed.  Closing bug.