Bug 165956 - More SQLiteIDBCursor refactoring
Summary: More SQLiteIDBCursor refactoring
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 160306 165928
  Show dependency treegraph
 
Reported: 2016-12-16 10:09 PST by Brady Eidson
Modified: 2016-12-16 15:04 PST (History)
5 users (show)

See Also:


Attachments
Patch (19.34 KB, patch)
2016-12-16 10:13 PST, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (12.70 KB, patch)
2016-12-16 10:14 PST, Brady Eidson
thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (1016.65 KB, application/zip)
2016-12-16 10:51 PST, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.05 MB, application/zip)
2016-12-16 11:05 PST, Build Bot
no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (770.13 KB, application/zip)
2016-12-16 11:06 PST, Build Bot
no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (14.32 MB, application/zip)
2016-12-16 11:20 PST, Build Bot
no flags Details
Patch for landing (12.90 KB, patch)
2016-12-16 13:23 PST, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-12-16 10:09:45 PST
More SQLiteIDBCursor refactoring

This is more groundwork for cursor prefetching
Comment 1 Brady Eidson 2016-12-16 10:13:09 PST
Created attachment 297320 [details]
Patch
Comment 2 Brady Eidson 2016-12-16 10:14:39 PST
Created attachment 297321 [details]
Patch
Comment 3 Tim Horton 2016-12-16 10:16:41 PST
Comment on attachment 297321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297321&action=review

> Source/WebCore/ChangeLog:18
> +        

This changelog could use some words.
Comment 4 Build Bot 2016-12-16 10:51:50 PST
Comment on attachment 297321 [details]
Patch

Attachment 297321 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2738335

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2016-12-16 10:51:52 PST
Created attachment 297326 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-12-16 11:05:56 PST
Comment on attachment 297321 [details]
Patch

Attachment 297321 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2738386

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2016-12-16 11:05:58 PST
Created attachment 297329 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-12-16 11:06:52 PST
Comment on attachment 297321 [details]
Patch

Attachment 297321 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2738377

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2016-12-16 11:06:55 PST
Created attachment 297330 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Build Bot 2016-12-16 11:20:01 PST
Comment on attachment 297321 [details]
Patch

Attachment 297321 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2738397

Number of test failures exceeded the failure limit.
Comment 11 Build Bot 2016-12-16 11:20:04 PST
Created attachment 297332 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 12 Brady Eidson 2016-12-16 13:23:33 PST
Created attachment 297350 [details]
Patch for landing
Comment 13 WebKit Commit Bot 2016-12-16 15:04:03 PST
Comment on attachment 297350 [details]
Patch for landing

Clearing flags on attachment: 297350

Committed r209942: <http://trac.webkit.org/changeset/209942>
Comment 14 WebKit Commit Bot 2016-12-16 15:04:08 PST
All reviewed patches have been landed.  Closing bug.