Created attachment 297310 [details] WebKit Nightly r209896 too light regular Skia rendering In WebKit Nightly r209896 and https://jsfiddle.net/whLa398b/1/ I get a lighter rendering for the regular variant at 1.0 wght value than at the lighter wght variant at 0.8 value. This was discovered while I was using the modified blog post jsfiddle as an example: https://jsfiddle.net/0v1wkpmz/ If I am not mistaken, the expected result is: The wght 0.8 instance should look lighter. Fonttools tells me both axes in Skia use 1.0 as their default value, so does the "Regular" named instance.
Created attachment 297311 [details] My unreleased Chrome dev version, for comparison
Yes, CoreText has a bug where applying the default value of a variation axis via the API causes, in reality, the minimum value of that axis to be applied. I need to work around this in WebKit.
*** Bug 163790 has been marked as a duplicate of this bug. ***
Created attachment 297531 [details] Patch
Comment on attachment 297531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297531&action=review > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:473 > + // FIXME: Remove when <rdar://problem/28707822> is fixed This is not indented correctly.
Created attachment 297533 [details] Patch for committing
Comment on attachment 297531 [details] Patch Attachment 297531 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2760321 New failing tests: imported/w3c/web-platform-tests/IndexedDB/interfaces.worker.html
Created attachment 297537 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 297533 [details] Patch for committing Attachment 297533 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2760351 New failing tests: fast/text/variations/outofbounds.html
Created attachment 297539 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 297531 [details] Patch Attachment 297531 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2760383 New failing tests: fast/text/variations/outofbounds.html
Created attachment 297540 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Committed r210054: <http://trac.webkit.org/changeset/210054>
Nightly only contained revisions up until r210021, I'll check tomorrow.
(In reply to comment #14) > Nightly only contained revisions up until r210021, I'll check tomorrow. Any word?
Created attachment 298100 [details] Screenshot Safari r210314 and Chromium ToT
Looks good to me on r210314, thanks!