RESOLVED FIXED 165942
i64.eqz should use an Int64 zero 
https://bugs.webkit.org/show_bug.cgi?id=165942
Summary i64.eqz should use an Int64 zero
Keith Miller
Reported 2016-12-15 19:32:21 PST
i64.eqz should use an Int64 zero
Attachments
Patch (6.51 KB, patch)
2016-12-15 20:10 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-12-15 20:10:55 PST
Created attachment 297293 [details] Patch
WebKit Commit Bot
Comment 2 2016-12-15 20:12:44 PST
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Mark Lam
Comment 3 2016-12-15 20:50:36 PST
Comment on attachment 297293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297293&action=review r=me with suggested change. > Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:268 > +inline const char* makeString(OpType op) I think "opName" would be a better name than "makeString".
Keith Miller
Comment 4 2016-12-16 09:18:14 PST
Comment on attachment 297293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297293&action=review >> Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:268 >> +inline const char* makeString(OpType op) > > I think "opName" would be a better name than "makeString". I chose makeString because it works with the new WasmParser.h failure template code.
WebKit Commit Bot
Comment 5 2016-12-16 09:54:03 PST
Comment on attachment 297293 [details] Patch Clearing flags on attachment: 297293 Committed r209923: <http://trac.webkit.org/changeset/209923>
WebKit Commit Bot
Comment 6 2016-12-16 09:54:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.