Bug 165938 - Fix validation of non-void if blocks with no else
Summary: Fix validation of non-void if blocks with no else
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-15 18:01 PST by Keith Miller
Modified: 2016-12-15 18:39 PST (History)
4 users (show)

See Also:


Attachments
Patch (4.59 KB, patch)
2016-12-15 18:04 PST, Keith Miller
sbarati: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-12-15 18:01:22 PST
Fix validation of non-void if blocks with no else
Comment 1 Keith Miller 2016-12-15 18:04:24 PST
Created attachment 297270 [details]
Patch
Comment 2 WebKit Commit Bot 2016-12-15 18:28:57 PST
Comment on attachment 297270 [details]
Patch

Rejecting attachment 297270 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 297270, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
a/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://webkit-queues.webkit.org/results/2733165
Comment 3 Keith Miller 2016-12-15 18:39:12 PST
Committed r209899: <http://trac.webkit.org/changeset/209899>