Bug 165934 - LayoutTest js/dom/global-constructors-attributes.html fails on certain configs
Summary: LayoutTest js/dom/global-constructors-attributes.html fails on certain configs
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-15 17:01 PST by Ryan Haddad
Modified: 2017-09-13 09:57 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-12-15 17:01:09 PST
LayoutTest js/dom/global-constructors-attributes.html fails on certain configs

https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK1%20(Tests)/r209883%20(12336)/results.html
Comment 1 Ryan Haddad 2016-12-15 17:09:18 PST
Marked as failing on El Capitan WK1 in http://trac.webkit.org/projects/webkit/changeset/209889
Comment 2 Alexey Proskuryakov 2016-12-15 17:32:59 PST
Are the differences expected? We already have lots of separate expectation files for Mac:

LayoutTests//platform/mac/js/dom/global-constructors-attributes-expected.txt
LayoutTests//platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt
LayoutTests//platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt

If this is unexpected, then it's a pretty big deal.
Comment 3 Ryan Haddad 2016-12-15 17:40:17 PST
(In reply to comment #2)
> Are the differences expected? We already have lots of separate expectation
> files for Mac:
> 
> LayoutTests//platform/mac/js/dom/global-constructors-attributes-expected.txt
> LayoutTests//platform/mac-wk1/js/dom/global-constructors-attributes-expected.
> txt
> LayoutTests//platform/mac-yosemite/js/dom/global-constructors-attributes-
> expected.txt
> 
> If this is unexpected, then it's a pretty big deal.

Yes, the differences seem to be expected. To avoid marking the test as failing, we would need to add an -expected.txt for mac-elcapitan-wk1 and mac-yosemite-wk1, which we don't currently support.
Comment 4 Matt Lewis 2017-09-13 09:57:09 PDT
Due to a change in how expectations and expected files work now, we support the new expected files, however this test has to go through extensive re-baselining when it or related code is changed. We will look at the differenced of the -expected.txt files to see if this behavior is expected or if there is a bug.