Bug 165931 - Stop reinterpret_casting UBreakIterators to the undefined type TextBreakIterator
Summary: Stop reinterpret_casting UBreakIterators to the undefined type TextBreakIterator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-15 16:39 PST by Myles C. Maxfield
Modified: 2016-12-16 08:20 PST (History)
2 users (show)

See Also:

Attachments
Patch (52.91 KB, patch)
2016-12-15 16:46 PST, Myles C. Maxfield 		achristensen: review+
mmaxfield: commit-queue-
Details | Formatted Diff | Diff
Patch for committing (53.08 KB, patch)
2016-12-15 17:26 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for committing (54.64 KB, patch)
2016-12-15 17:46 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for committing (54.79 KB, patch)
2016-12-15 18:24 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for committing (59.35 KB, patch)
2016-12-15 19:45 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for committing (59.57 KB, patch)
2016-12-15 20:24 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for committing (59.57 KB, patch)
2016-12-15 20:41 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for committing (59.57 KB, patch)
2016-12-15 20:42 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-12-15 16:39:51 PST 
Stop reinterpret_casting UBreakIterators to the undefined type TextBreakIterator
Comment 1 Myles C. Maxfield 2016-12-15 16:46:29 PST 
Created attachment 297253 [details]
Patch
Comment 2 Myles C. Maxfield 2016-12-15 17:26:01 PST 
Created attachment 297263 [details]
Patch for committing
Comment 3 Myles C. Maxfield 2016-12-15 17:46:35 PST 
Created attachment 297267 [details]
Patch for committing
Comment 4 Myles C. Maxfield 2016-12-15 18:24:40 PST 
Created attachment 297277 [details]
Patch for committing
Comment 5 Darin Adler 2016-12-15 18:38:20 PST 
Comment on attachment 297253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297253&action=review

> Source/WebCore/editing/TextCheckingHelper.cpp:83
> +    for (int wordStart = ubrk_current(iterator); wordStart >= 0; ) {
> +        int wordEnd = ubrk_next(iterator);

Looks like this file needs to include <unicode/ubrk.h> to compile on Windows:

C:\cygwin\home\buildbot\WebKit\Source\WebCore\editing\TextCheckingHelper.cpp(82): error C3861: 'ubrk_current': identifier not found (compiling source file C:\cygwin\home\buildbot\WebKit\Source\WebCore\editing\EditingAllInOne.cpp) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\WebKit\Source\WebCore\editing\TextCheckingHelper.cpp(83): error C3861: 'ubrk_next': identifier not found (compiling source file C:\cygwin\home\buildbot\WebKit\Source\WebCore\editing\EditingAllInOne.cpp) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
Comment 6 Darin Adler 2016-12-15 18:38:57 PST 
Oh, I see you were already trying to fix that.
Comment 7 Myles C. Maxfield 2016-12-15 19:45:13 PST 
Created attachment 297289 [details]
Patch for committing
Comment 8 Myles C. Maxfield 2016-12-15 20:24:58 PST 
Created attachment 297295 [details]
Patch for committing
Comment 9 Myles C. Maxfield 2016-12-15 20:41:45 PST 
Created attachment 297296 [details]
Patch for committing
Comment 10 Myles C. Maxfield 2016-12-15 20:42:37 PST 
Created attachment 297297 [details]
Patch for committing
Comment 11 WebKit Commit Bot 2016-12-15 21:20:10 PST 
Comment on attachment 297297 [details]
Patch for committing

Clearing flags on attachment: 297297

Committed r209907: <http://trac.webkit.org/changeset/209907>
Comment 12 Myles C. Maxfield 2016-12-16 08:20:43 PST 
Build fix at https://trac.webkit.org/changeset/209913