Bug 165914 - Add more mach_msg logging instrumentation
Summary: Add more mach_msg logging instrumentation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-15 12:43 PST by Anders Carlsson
Modified: 2016-12-15 14:48 PST (History)
0 users

See Also:

Attachments
Patch (2.75 KB, patch)
2016-12-15 12:46 PST, Anders Carlsson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-12-15 12:43:46 PST 
Add more mach_msg logging instrumentation
Comment 1 Anders Carlsson 2016-12-15 12:46:18 PST 
Created attachment 297212 [details]
Patch
Comment 2 Darin Adler 2016-12-15 12:50:21 PST 
Comment on attachment 297212 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297212&action=review

> Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm:286
> +        WKSetCrashReportApplicationSpecificInformation((CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x, message '%@'", kr, message->messageName()]);

Wish we had bridging_cast to use in places like this.

> Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm:321
> +    message->setMessageName((__bridge CFStringRef)[NSString stringWithFormat:@"%s:%s:", encoder->messageReceiverName().toString().data(), encoder->messageName().toString().data()]);

Ditto.
Comment 3 Anders Carlsson 2016-12-15 14:48:50 PST 
Committed r209876: <http://trac.webkit.org/changeset/209876>