RESOLVED FIXED 165914
Add more mach_msg logging instrumentation 
https://bugs.webkit.org/show_bug.cgi?id=165914
Summary Add more mach_msg logging instrumentation
Anders Carlsson
Reported 2016-12-15 12:43:46 PST
Add more mach_msg logging instrumentation
Attachments
Patch (2.75 KB, patch)
2016-12-15 12:46 PST, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2016-12-15 12:46:18 PST
Created attachment 297212 [details] Patch
Darin Adler
Comment 2 2016-12-15 12:50:21 PST
Comment on attachment 297212 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297212&action=review > Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm:286 > + WKSetCrashReportApplicationSpecificInformation((CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x, message '%@'", kr, message->messageName()]); Wish we had bridging_cast to use in places like this. > Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm:321 > + message->setMessageName((__bridge CFStringRef)[NSString stringWithFormat:@"%s:%s:", encoder->messageReceiverName().toString().data(), encoder->messageName().toString().data()]); Ditto.
Anders Carlsson
Comment 3 2016-12-15 14:48:50 PST
Committed r209876: <http://trac.webkit.org/changeset/209876>
Note You need to log in before you can comment on or make changes to this bug.