Bug 165913 – [WebCrypto] WebInspector should indicate webkitSubtle is deprecated

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jiewen Tan]

Since the new subtle code is completed, we should probably emit a WebInspector console log message indicating that “webkitSubtle” is deprecated.

[Radar WebKit Bug Importer]

<rdar://problem/30477222>

[Jiewen Tan]

Created attachment 301231 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 301231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301231&action=review

r=me

> Source/WebCore/bindings/js/JSWebKitSubtleCryptoCustom.cpp:130
> +static void addDeprecationWarningToConsole(ExecState& state)
> +{
> +    scriptExecutionContextFromExecState(&state)->addConsoleMessage(MessageSource::JS, MessageLevel::Warning, ASCIILiteral("WebKitSubtleCrypto is deprecated. Please use SubtleCrypto instead."));
> +}

Can we instead just warn once if somebody accesses global.webkitSubtleCrypto?

Essentially in, Crypto::webkitSubtle(). Then it will be very easy to warn a single time per-page that accesses it.

[Joseph Pecoraro]

> r=me

Err, no review given my question.

[Jiewen Tan]

Comment on attachment 301231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301231&action=review

>> Source/WebCore/bindings/js/JSWebKitSubtleCryptoCustom.cpp:130
>> +}
> 
> Can we instead just warn once if somebody accesses global.webkitSubtleCrypto?
> 
> Essentially in, Crypto::webkitSubtle(). Then it will be very easy to warn a single time per-page that accesses it.

Sure. My bad. I was thinking webkitSubtle only before. Actually, I should put the check on crypto.

[Jiewen Tan]

Created attachment 301363 [details]
Patch

[Build Bot]

Comment on attachment 301363 [details]
Patch

Attachment 301363 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3079082

New failing tests:
fast/dom/Window/property-access-on-cached-window-after-frame-removed.html

[Build Bot]

Created attachment 301373 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 301363 [details]
Patch

Attachment 301363 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3079087

New failing tests:
fast/dom/Window/property-access-on-cached-window-after-frame-removed.html

[Build Bot]

Created attachment 301374 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 301363 [details]
Patch

Attachment 301363 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3079083

New failing tests:
fast/dom/Window/property-access-on-cached-window-after-frame-removed.html

[Build Bot]

Created attachment 301376 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 301363 [details]
Patch

Attachment 301363 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3079096

New failing tests:
fast/dom/Window/property-access-on-cached-window-after-frame-removed.html

[Build Bot]

Created attachment 301377 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Joseph Pecoraro]

Comment on attachment 301363 [details]
Patch

r=me, though you should rebaseline the other test

[Jiewen Tan]

Created attachment 301387 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 301387 [details]
Patch for landing

Clearing flags on attachment: 301387

Committed r212261: <http://trac.webkit.org/changeset/212261>

[Yury Strozhevsky]

Hello!

Can someone solved the bug make a comment in this bug? https://bugs.webkit.org/show_bug.cgi?id=170446

The bug I was mentioned has title "Exception when trying to get self.crypto.webkitSubtle in WebWorker" and Alexey Proskuryakov was closing the bug two times with remarks "not a bug at all". But I do hope we should have only a warning in console during accesing webkitSubtle, not an exception.

Thank you in advance.

[Jiewen Tan]

(In reply to Yury Strozhevsky from comment #18)
> Hello!
> 
> Can someone solved the bug make a comment in this bug?
> https://bugs.webkit.org/show_bug.cgi?id=170446
> 
> The bug I was mentioned has title "Exception when trying to get
> self.crypto.webkitSubtle in WebWorker" and Alexey Proskuryakov was closing
> the bug two times with remarks "not a bug at all". But I do hope we should
> have only a warning in console during accesing webkitSubtle, not an
> exception.
> 
> Thank you in advance.

Hi Yuri, regarding to your specific problem, the issue is that we didn't support webkitSubtle in workers from the very beginning. Therefore, you get an exception. There is nothing to do with this deprecation. If you call webkitSubtle in the main document instead of workers, you should get a warning and no exceptions.