SlotVisitor has a bunch of stuff left over from ancient attempts to make our GC be fully copying. We're all-in with the non-copying religion now, so we might as well get rid of the heresy.
Created attachment 297209 [details] it's a start
Created attachment 297215 [details] a bit more
Created attachment 297223 [details] more
Created attachment 297229 [details] the patch
This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)
Attachment 297229 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/heap/SlotVisitor.h:92: The parameter name "weak" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 113 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 297229 [details] the patch r=me I don't really love "appendTrusted". We trust all our pointers to be valid pointers. Maybe "appendWithoutBarrierCheck"?
(In reply to comment #7) > Comment on attachment 297229 [details] > the patch > > r=me > > I don't really love "appendTrusted". We trust all our pointers to be valid > pointers. > > Maybe "appendWithoutBarrierCheck"? We call this a lot so I was hoping for something short. appendUnbarriered?
Comment on attachment 297229 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=297229&action=review > Source/JavaScriptCore/Scripts/builtins/builtins_templates.py:208 > +#define VISIT_FUNCTION(name) visitor.append(m_##name##Function); You'll need to rebaseline, run-builtins-generator-tests --reset-results
(In reply to comment #9) > Comment on attachment 297229 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=297229&action=review > > > Source/JavaScriptCore/Scripts/builtins/builtins_templates.py:208 > > +#define VISIT_FUNCTION(name) visitor.append(m_##name##Function); > > You'll need to rebaseline, run-builtins-generator-tests --reset-results Done!
Landed in https://trac.webkit.org/changeset/209897
(In reply to comment #11) > Landed in https://trac.webkit.org/changeset/209897 It broke the bindings generation tests, see build.webkit.org for details.
Rebaselined bindings tests in http://trac.webkit.org/projects/webkit/changeset/209925
(In reply to comment #13) > Rebaselined bindings tests in > http://trac.webkit.org/projects/webkit/changeset/209925 Thank you!