Bug 165906 - Inline Document::existingAXObjectCache()
Summary: Inline Document::existingAXObjectCache()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-15 10:58 PST by Chris Dumez
Modified: 2016-12-15 13:09 PST (History)
7 users (show)

See Also:


Attachments
Patch (3.06 KB, patch)
2016-12-15 10:59 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-12-15 10:58:33 PST
Inline Document::existingAXObjectCache() to avoid paying function call cost in the common case where AX is disabled.
Comment 1 Chris Dumez 2016-12-15 10:59:48 PST
Created attachment 297202 [details]
Patch
Comment 2 Darin Adler 2016-12-15 12:43:20 PST
Comment on attachment 297202 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297202&action=review

> Source/WebCore/dom/Document.cpp:278
> +bool Document::hasEverCreatedAnAXObjectCache = false;

I see no code in this patch setting this to true.
Comment 3 Darin Adler 2016-12-15 12:43:50 PST
Comment on attachment 297202 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297202&action=review

>> Source/WebCore/dom/Document.cpp:278
>> +bool Document::hasEverCreatedAnAXObjectCache = false;
> 
> I see no code in this patch setting this to true.

Oops, I see now. The flag already existed.
Comment 4 WebKit Commit Bot 2016-12-15 13:09:16 PST
Comment on attachment 297202 [details]
Patch

Clearing flags on attachment: 297202

Committed r209870: <http://trac.webkit.org/changeset/209870>
Comment 5 WebKit Commit Bot 2016-12-15 13:09:21 PST
All reviewed patches have been landed.  Closing bug.