Bug 165903 - Added missing override and final specifiers
Summary: Added missing override and final specifiers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-15 10:29 PST by Konstantin Tokarev
Modified: 2016-12-15 13:33 PST (History)
2 users (show)

See Also:

Attachments
Patch (81.97 KB, patch)
2016-12-15 10:31 PST, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Patch (81.89 KB, patch)
2016-12-15 10:40 PST, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-12-15 10:29:18 PST 
Added missing override and final specifiers as detected by clang-tidy. 'final' is used instead of override in final classes.
Comment 1 Konstantin Tokarev 2016-12-15 10:31:46 PST 
Created attachment 297199 [details]
Patch
Comment 2 Konstantin Tokarev 2016-12-15 10:40:47 PST 
Created attachment 297200 [details]
Patch
Comment 3 Darin Adler 2016-12-15 12:47:58 PST 
Comment on attachment 297200 [details]
Patch

Another thing that would be nice to do would be marking more classes final. Lots of these classes seem to be final. Any class that has no classes deriving from it should probably get marked that way. We can always remove it later if we want to derive a class from it.

And also, any function that is not overridden further could be marked final even if the class is not final.
Comment 4 Konstantin Tokarev 2016-12-15 13:26:47 PST 
Comment on attachment 297200 [details]
Patch

Clearing flags on attachment: 297200

Committed r209871: <http://trac.webkit.org/changeset/209871>
Comment 5 Konstantin Tokarev 2016-12-15 13:26:54 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Konstantin Tokarev 2016-12-15 13:33:25 PST 
Yes, but such changes require more careful attitude, and have more potential of breaking build for some untested ports, so it's better to do them separately step by step