Bug 165902 - Fix 64-bit shift family Wasm opcodes
Summary: Fix 64-bit shift family Wasm opcodes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-15 10:14 PST by Keith Miller
Modified: 2016-12-15 11:17 PST (History)
5 users (show)

See Also:

Attachments
Patch (18.56 KB, patch)
2016-12-15 10:20 PST, Keith Miller 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-12-15 10:14:04 PST 
Fix 64-bit shift family Wasm opcodes
Comment 1 Keith Miller 2016-12-15 10:20:23 PST 
Created attachment 297198 [details]
Patch
Comment 2 WebKit Commit Bot 2016-12-15 10:21:32 PST 
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Comment 3 Geoffrey Garen 2016-12-15 10:22:38 PST 
Comment on attachment 297198 [details]
Patch

r=me
Comment 4 JF Bastien 2016-12-15 10:25:49 PST 
Comment on attachment 297198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297198&action=review

> JSTests/wasm/function-tests/rotl.js:22
> +          .End()

It should be a validation error to export a function with i64. Why does this pass?
Comment 5 JF Bastien 2016-12-15 10:26:54 PST 
You could test the i64 stuff by doing i32 -ext-> i64, and then using the ops. Pass in 2 xx i32 from JS, or them together.
Comment 6 Keith Miller 2016-12-15 11:16:35 PST 
Comment on attachment 297198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297198&action=review

>> JSTests/wasm/function-tests/rotl.js:22
>> +          .End()
> 
> It should be a validation error to export a function with i64. Why does this pass?

I don't think this is true. You just can't call (from JS) an exported function that takes/returns an i64.
Comment 7 Keith Miller 2016-12-15 11:17:43 PST 
Committed r209866: <http://trac.webkit.org/changeset/209866>