Bug 16590 - Solaris OS compile fix
Summary: Solaris OS compile fix
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.4
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2007-12-23 15:29 PST by Holger Freyther
Modified: 2008-01-13 11:48 PST (History)
1 user (show)

See Also:

Solaris Compile fix from Adrian de Groot (2.88 KB, patch)
2007-12-23 15:30 PST, Holger Freyther
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2007-12-23 15:29:41 PST
kjs currently does not compile on Solaris OS. We have fix from Adrian de Groot in the QtWebkit branch, this patch is also in the KDE version of kjs.
Comment 1 Holger Freyther 2007-12-23 15:30:48 PST
Created attachment 18080 [details]
Solaris Compile fix from Adrian de Groot

Compile fix for Solaris OS and non GNU compilers.
Comment 2 Eric Seidel (no email) 2007-12-23 16:58:45 PST
Comment on attachment 18080 [details]
Solaris Compile fix from Adrian de Groot

Looks fine.  strange that: isinf would use one NaN test and isfinite would use a different one.  Perhaps we should fix that before landing.  !isNan() is clearer.
Comment 3 Maciej Stachowiak 2007-12-25 14:49:28 PST
It would be better if these were written as inline functions, not #defines:

+#include <ieeefp.h>
+#if !defined(isfinite)
+#define isfinite(x) (finite(x) && !isnand(x))
+#if !defined(isinf)
+#define isinf(x) (!finite(x) && (x == x))
+#if !defined(signbit)
+#define signbit(x) (x < 0.0)

Please fix when landing.
Comment 4 Mark Rowe (bdash) 2008-01-03 00:35:06 PST
Does SOLARIS_OS need the _OS suffix?  The reason for the _OS suffix on WIN is to distinguish between the base platform and the higher-level APIs.  Does Solaris also refer to a higher-level environment to which WebKit may one day be ported?  My understanding was that it runs X with GNOME, thus the Gtk or Qt ports would provide this higher layer.
Comment 5 Darin Adler 2008-01-13 11:48:42 PST
Committed revision 29454.

I considered all the comments in this bug.

The implementation of signbit is definitely incorrect, so I added a FIXME.