Bug 165896 - [EFL] Disable non-srcdir builds for failing libraries
Summary: [EFL] Disable non-srcdir builds for failing libraries
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hunseop Jeong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-15 01:55 PST by Hunseop Jeong
Modified: 2016-12-16 05:37 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.52 KB, patch)
2016-12-15 02:35 PST, Hunseop Jeong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hunseop Jeong 2016-12-15 01:55:02 PST
After update the jhbuild, Some libraries fail to build the library.
Comment 1 Hunseop Jeong 2016-12-15 02:35:06 PST
Created attachment 297187 [details]
Patch
Comment 2 Hunseop Jeong 2016-12-15 02:36:16 PST
[GTK][EFL] Update the JHBuild version.
http://trac.webkit.org/changeset/209804
Comment 3 Gyuyoung Kim 2016-12-15 17:54:48 PST
Comment on attachment 297187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297187&action=review

> Tools/ChangeLog:8
> +        * efl/jhbuild.modules: Set non srcdir builds to no

Is it fine to skip the build of non-src directory modules ? Shouldn't we find proper directory ?
Comment 4 Hunseop Jeong 2016-12-15 18:14:32 PST
(In reply to comment #3)
> Comment on attachment 297187 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=297187&action=review
> 
> > Tools/ChangeLog:8
> > +        * efl/jhbuild.modules: Set non srcdir builds to no
> 
> Is it fine to skip the build of non-src directory modules ? Shouldn't we
> find proper directory ?

I tested it and it worked fine. 
If we didn't set the non-src builds to no, 'update-webkitefl-libs' failed to build the libraies.
Anyway I will check one more to find the proper directory.
Comment 5 Gyuyoung Kim 2016-12-15 18:28:27 PST
Comment on attachment 297187 [details]
Patch

Ok, please land it after checking it one more time.
Comment 6 WebKit Commit Bot 2016-12-16 05:37:26 PST
Comment on attachment 297187 [details]
Patch

Clearing flags on attachment: 297187

Committed r209918: <http://trac.webkit.org/changeset/209918>
Comment 7 WebKit Commit Bot 2016-12-16 05:37:30 PST
All reviewed patches have been landed.  Closing bug.