WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
165896
[EFL] Disable non-srcdir builds for failing libraries
https://bugs.webkit.org/show_bug.cgi?id=165896
Summary
[EFL] Disable non-srcdir builds for failing libraries
Hunseop Jeong
Reported
2016-12-15 01:55:02 PST
After update the jhbuild, Some libraries fail to build the library.
Attachments
Patch
(2.52 KB, patch)
2016-12-15 02:35 PST
,
Hunseop Jeong
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Hunseop Jeong
Comment 1
2016-12-15 02:35:06 PST
Created
attachment 297187
[details]
Patch
Hunseop Jeong
Comment 2
2016-12-15 02:36:16 PST
[GTK][EFL] Update the JHBuild version.
http://trac.webkit.org/changeset/209804
Gyuyoung Kim
Comment 3
2016-12-15 17:54:48 PST
Comment on
attachment 297187
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=297187&action=review
> Tools/ChangeLog:8 > + * efl/jhbuild.modules: Set non srcdir builds to no
Is it fine to skip the build of non-src directory modules ? Shouldn't we find proper directory ?
Hunseop Jeong
Comment 4
2016-12-15 18:14:32 PST
(In reply to
comment #3
)
> Comment on
attachment 297187
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=297187&action=review
> > > Tools/ChangeLog:8 > > + * efl/jhbuild.modules: Set non srcdir builds to no > > Is it fine to skip the build of non-src directory modules ? Shouldn't we > find proper directory ?
I tested it and it worked fine. If we didn't set the non-src builds to no, 'update-webkitefl-libs' failed to build the libraies. Anyway I will check one more to find the proper directory.
Gyuyoung Kim
Comment 5
2016-12-15 18:28:27 PST
Comment on
attachment 297187
[details]
Patch Ok, please land it after checking it one more time.
WebKit Commit Bot
Comment 6
2016-12-16 05:37:26 PST
Comment on
attachment 297187
[details]
Patch Clearing flags on attachment: 297187 Committed
r209918
: <
http://trac.webkit.org/changeset/209918
>
WebKit Commit Bot
Comment 7
2016-12-16 05:37:30 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug