Bug 165882 - DirectTailCall implementation needs to tell the shuffler what to put into the ArgumentCount explicitly
Summary: DirectTailCall implementation needs to tell the shuffler what to put into the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
: 166642 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-12-14 17:03 PST by Filip Pizlo
Modified: 2017-01-03 14:21 PST (History)
10 users (show)

See Also:

Attachments
the patch (9.91 KB, patch)
2016-12-14 17:09 PST, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-12-14 17:03:25 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-12-14 17:09:39 PST 
Created attachment 297147 [details]
the patch
Comment 2 Mark Lam 2016-12-14 17:23:48 PST 
Comment on attachment 297147 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297147&action=review

LGTM.

> Source/WTF/wtf/Platform.h:893
> -#if (CPU(X86) || CPU(X86_64) || CPU(ARM64) || (CPU(ARM_THUMB2) && PLATFORM(IOS))) && ENABLE(JIT) && OS(DARWIN) && !defined(NDEBUG)
> +#if (CPU(X86) || CPU(X86_64) || CPU(ARM64) || (CPU(ARM_THUMB2) && PLATFORM(IOS))) && ENABLE(JIT) && OS(DARWIN)

I presume this was not deliberate but leftover from a debugging session?  If so, please undo.
Comment 3 Filip Pizlo 2016-12-14 17:24:39 PST 
(In reply to comment #2)
> Comment on attachment 297147 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=297147&action=review
> 
> LGTM.
> 
> > Source/WTF/wtf/Platform.h:893
> > -#if (CPU(X86) || CPU(X86_64) || CPU(ARM64) || (CPU(ARM_THUMB2) && PLATFORM(IOS))) && ENABLE(JIT) && OS(DARWIN) && !defined(NDEBUG)
> > +#if (CPU(X86) || CPU(X86_64) || CPU(ARM64) || (CPU(ARM_THUMB2) && PLATFORM(IOS))) && ENABLE(JIT) && OS(DARWIN)
> 
> I presume this was not deliberate but leftover from a debugging session?  If
> so, please undo.

Will do!
Comment 4 Filip Pizlo 2016-12-14 17:26:12 PST 
Landed in https://trac.webkit.org/changeset/209846
Comment 5 Alexey Proskuryakov 2017-01-03 14:21:00 PST 
*** Bug 166642 has been marked as a duplicate of this bug. ***