WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
165875
ScriptFunctionCall::call() can return an empty JSValue if the watchdog timer fires, callers should check for this
https://bugs.webkit.org/show_bug.cgi?id=165875
Summary
ScriptFunctionCall::call() can return an empty JSValue if the watchdog timer ...
Michael Saboff
Reported
2016-12-14 15:06:22 PST
Many callers of ScriptFunctionCall::call() assume that it returns a valid, non-empty JSValue. Most of these callers do not check for this. They should be fixed as appropriate.
Attachments
Add attachment
proposed patch, testcase, etc.
Michael Saboff
Comment 1
2016-12-14 15:33:44 PST
rdar://problem/29671015
Yury Semikhatsky
Comment 2
2023-11-10 18:20:29 PST
We've crashes due to an empty value on Windows around this call in particular
https://github.com/WebKit/WebKit/blob/020f297aadfe1e55b3d238dfc7922cfa193ceae3/Source/JavaScriptCore/inspector/InjectedScript.cpp#L292
in Playwright.
Yury Semikhatsky
Comment 3
2023-11-10 18:33:41 PST
Pull request:
https://github.com/WebKit/WebKit/pull/20353
EWS
Comment 4
2023-11-14 18:25:08 PST
Committed
270739@main
(a4eed62b176c): <
https://commits.webkit.org/270739@main
> Reviewed commits have been landed. Closing PR #20353 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug