Bug 165872 - REGRESSION (204679): Google notifications never load (expecting DOMStringList rather than JS array for Location.ancestorOrigins)
Summary: REGRESSION (204679): Google notifications never load (expecting DOMStringList...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-14 14:42 PST by Sam Weinig
Modified: 2016-12-14 16:04 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.77 KB, patch)
2016-12-14 14:48 PST, Sam Weinig 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2016-12-14 14:42:53 PST 
REGRESSION (204679): Google notifications never load (expecting DOMStringList rather than JS array for Location.ancestorOrigins)
Comment 1 Sam Weinig 2016-12-14 14:44:29 PST 
Chris file https://github.com/whatwg/html/issues/2179 to track this on the spec side. 

Since Chrome is still returning a DOMStringList, and this is breaking the front page of Google, we should revert the Location.ancestorOrigins change from r204679.
Comment 2 Sam Weinig 2016-12-14 14:44:44 PST 
<rdar://problem/29573563>
Comment 3 Sam Weinig 2016-12-14 14:48:21 PST 
Created attachment 297128 [details]
Patch
Comment 4 Chris Dumez 2016-12-14 15:07:21 PST 
Comment on attachment 297128 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297128&action=review

r=me

> Source/WebCore/page/Location.idl:61
> +    // FIXME: This should return a FixedArray<DOMString> and should use SameObject.

FixedArray? Did you mean FrozenArray? I believe the spec will be reverted to DOMStringList as per comment on the spec bug so we may not need to update this comment at all.
Comment 5 Sam Weinig 2016-12-14 16:04:36 PST 
Committed r209841: <http://trac.webkit.org/changeset/209841>