Bug 165857 – [JSC] Optimize Kraken stringify

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Yusuke Suzuki]

In Kraken's stringify test, roughly 30% of time is used by StringBuilder::appendQuotedJSONString.
I think we have room for optimization in this function.

I have a patch that shows 1% performance improvement in Linux box, but I need to test it with macOS clang.

[Yusuke Suzuki]

Created attachment 297100 [details]
Patch

WIP: Linux box shows 1% improvement

[Yusuke Suzuki]

Created attachment 297101 [details]
Patch

WIP: Linux box shows 4.6% improvement

[Yusuke Suzuki]

Created attachment 297179 [details]
Patch

[Yusuke Suzuki]

Created attachment 297183 [details]
Patch

[Darin Adler]

Comment on attachment 297183 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297183&action=review

> Source/WTF/wtf/text/StringBuilder.cpp:429
> +        if (LIKELY(character != '"' && character != '\\' && character > 0x1F)) {

For 8-bit characters can we make it even faster with a 256 byte array?

[Yusuke Suzuki]

Comment on attachment 297183 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297183&action=review

>> Source/WTF/wtf/text/StringBuilder.cpp:429
>> +        if (LIKELY(character != '"' && character != '\\' && character > 0x1F)) {
> 
> For 8-bit characters can we make it even faster with a 256 byte array?

I've created additional two versions.

1. Bit packed array version.

451         static constexpr const uint64_t masks[4] = {
452             0xfffffffb00000000ULL,
453             0xffffffffefffffffULL,
454             0xffffffffffffffffULL,
455             0xffffffffffffffffULL,
456         };
457
458         if (masks[character >> 6]  & (1ULL << (character & 0b111111))) {
459             *output++ = character;
460             continue;
461         }

2. 256 bytes array version.

The result on MBP.

                                   256array                   branch                   packed    

json-stringify-tinderbox        27.237+-0.212             27.157+-0.196      ?      27.239+-0.213

Overall, they show the same results. I think this is because branch prediction works well.
So I think the current version is OK.

BTW, if we put it on the Aarch64 cores, it could show the different results because Intel cores has sophisticated branch predictions.

[WebKit Commit Bot]

Comment on attachment 297183 [details]
Patch

Clearing flags on attachment: 297183

Committed r209858: <http://trac.webkit.org/changeset/209858>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.