Bug 165849 - [ES6] Enable ES6 Modules
Summary: [ES6] Enable ES6 Modules
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 147340
  Show dependency tree / graph
 
Reported: 2016-12-14 08:19 PST by Yusuke Suzuki
Modified: 2016-12-20 00:33 PST (History)
17 users (show)

See Also:

Attachments
Patch (23.53 KB, patch)
2016-12-18 21:35 PST, Yusuke Suzuki 		ggaren: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews115 for mac-yosemite (1.58 MB, application/zip)
2016-12-18 22:46 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2016-12-14 08:19:48 PST 
The major functionalities are landed.
We can enable it.
Comment 1 Yusuke Suzuki 2016-12-18 21:35:07 PST 
Created attachment 297452 [details]
Patch
Comment 2 Build Bot 2016-12-18 22:46:40 PST 
Comment on attachment 297452 [details]
Patch

Attachment 297452 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2752210

New failing tests:
imported/w3c/web-platform-tests/IndexedDB/interfaces.worker.html
Comment 3 Build Bot 2016-12-18 22:46:45 PST 
Created attachment 297454 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Geoffrey Garen 2016-12-19 12:33:34 PST 
Comment on attachment 297452 [details]
Patch

r=me
Comment 5 Radar WebKit Bug Importer 2016-12-19 12:34:37 PST 
<rdar://problem/29739497>
Comment 6 WebKit Commit Bot 2016-12-19 12:41:04 PST 
Comment on attachment 297452 [details]
Patch

Rejecting attachment 297452 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
es/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCoreTestSupport.build/Objects-normal/x86_64/WebCoreTestSupport.o

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCoreTestSupport.build/Objects-normal/x86_64/JSInternalSettingsGenerated.o /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSInternalSettingsGenerated.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full output: http://webkit-queues.webkit.org/results/2755493
Comment 7 Yusuke Suzuki 2016-12-20 00:33:37 PST 
Committed r210016: <http://trac.webkit.org/changeset/210016>