Bug 165840 - EventDispatcher::dispatchEvent() should take its Node by reference
Summary: EventDispatcher::dispatchEvent() should take its Node by reference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-13 22:57 PST by Andy Estes
Modified: 2016-12-14 09:42 PST (History)
11 users (show)

See Also:

Attachments
Patch (10.24 KB, patch)
2016-12-13 23:11 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (10.15 KB, patch)
2016-12-13 23:22 PST, Andy Estes 		kling: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2016-12-13 22:57:07 PST 
EventDispatcher::dispatchEvent() should take its Node by reference
Comment 1 Andy Estes 2016-12-13 23:11:39 PST 
Created attachment 297067 [details]
Patch
Comment 2 Andy Estes 2016-12-13 23:16:59 PST 
Comment on attachment 297067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297067&action=review

Now that I think about it,

> Source/WebCore/dom/EventDispatcher.cpp:105
> -bool EventDispatcher::dispatchEvent(Node* origin, Event& event)
> +bool EventDispatcher::dispatchEvent(Node& origin, Event& event)

I'm not sure why the event target Node is called "origin". Seems backwards. Should probably just call it node (and call the protector protectedNode).
Comment 3 Andy Estes 2016-12-13 23:22:47 PST 
Created attachment 297069 [details]
Patch
Comment 4 WebKit Commit Bot 2016-12-14 08:07:28 PST 
Comment on attachment 297069 [details]
Patch

Rejecting attachment 297069 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 297069, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/git.webkit.org/WebKit
   a2f933b..73149b7  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 209800 = a2f933b1456de7b68405d390ebe56c263c04783d
r209801 = 73149b708675ee6f83d13211b897ee7f156aad11
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/2721147
Comment 5 Andy Estes 2016-12-14 09:42:36 PST 
Committed r209811: <https://trac.webkit.org/changeset/209811>