WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
Bug 16583
Speedup date code (msToGregorianDateTime) by only handling positive values
https://bugs.webkit.org/show_bug.cgi?id=16583
Summary
Speedup date code (msToGregorianDateTime) by only handling positive values
Eric Seidel (no email)
Reported
2007-12-23 01:52:28 PST
Speedup date code (msToGregorianDateTime) by only handling positive values msToGregorianDateTime and the associated static inline support functions are slow due to needing to handle negative values for ms. Instead we should detect that ms is negative, flip the sign, send it through normal processing and then flip the signs on the resulting GregorianDateTime. This would add a branch, but would greatly speed up date processing due to the removal of all of the floor() calls.
Attachments
Add attachment
proposed patch, testcase, etc.
Gavin Barraclough
Comment 1
2012-09-07 12:35:48 PDT
flipping the sign would not in itself allow us to remove calls to floor. Our date math has changed a lot in the last 4 years, I don't think this bug is still tracking active optimization effort.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug